[7.11] [Security Solution][Detections] Pre-refactoring for the rule management table (#91302)#92585
Closed
banderror wants to merge 1 commit intoelastic:7.11from
Closed
[7.11] [Security Solution][Detections] Pre-refactoring for the rule management table (#91302)#92585banderror wants to merge 1 commit intoelastic:7.11from
banderror wants to merge 1 commit intoelastic:7.11from
Conversation
…nt table (elastic#91302) **Related to:** elastic#89877 ## Summary This is based on elastic#89877 and the kind of pre-refactoring that has been done there. Mainly this: - consolidates application logic in a single place (moves the reducer and the side effects close to each other, etc) - removes some of the redundant state, leverages the reducer as the source of truth for state - makes it easier to dispatch events, removes some of the noise While this refactoring is a totally unfinished work, and might look not good enough (or at all), still I'd like to merge it because of the logic consolidation. I'm going to finalize the refactoring later when I start implementing new filters and other table UX improvements. So the code is going to become better and maybe even quite different from what it is right now. (Btw because of that, I'm not adding or removing any tests here because this is an intermediate kind of state of the code). ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios # Conflicts: # x-pack/plugins/security_solution/public/detections/pages/detection_engine/rules/all/rules_tables.tsx
Contributor
💔 Build Failed
Failed CI StepsMetrics [docs]Module Count
Async chunks
To update your PR or re-run it, just comment with: |
Contributor
Author
|
On hold for now. |
Contributor
Author
|
Backport rejected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.11:
This PR depends on #92601
7.11branch