fix issue with hiding loading message in embedded mode#9235
Merged
stacey-gammon merged 2 commits intoelastic:masterfrom Nov 28, 2016
Merged
Conversation
Contributor
|
LGTM |
Member
|
LGTM. There is another issue this brings up, which is the share embedded link includes |
This chunk of logic only matched on =embed, not =embed=true, which is what the url given by sharing uses.
Author
|
Great point @tylersmalley, I updated the regex to match on both. |
tylersmalley
approved these changes
Nov 28, 2016
Contributor
|
LGTM nice catch @tylersmalley |
elastic-jasper
added a commit
that referenced
this pull request
Nov 28, 2016
Backports PR #9235 **Commit 1:** fix issue with hiding loading message in embedded mode * Original sha: a5d4aaa * Authored by Stacey Gammon <gammon@elastic.co> on 2016-11-28T19:06:49Z **Commit 2:** Fix match as well This chunk of logic only matched on =embed, not =embed=true, which is what the url given by sharing uses. * Original sha: 1f6d7d9 * Authored by Stacey Gammon <gammon@elastic.co> on 2016-11-28T20:51:20Z
elastic-jasper
added a commit
that referenced
this pull request
Nov 28, 2016
Backports PR #9235 **Commit 1:** fix issue with hiding loading message in embedded mode * Original sha: a5d4aaa * Authored by Stacey Gammon <gammon@elastic.co> on 2016-11-28T19:06:49Z **Commit 2:** Fix match as well This chunk of logic only matched on =embed, not =embed=true, which is what the url given by sharing uses. * Original sha: 1f6d7d9 * Authored by Stacey Gammon <gammon@elastic.co> on 2016-11-28T20:51:20Z
This was referenced Nov 28, 2016
stacey-gammon
pushed a commit
that referenced
this pull request
Nov 28, 2016
Backports PR #9235 **Commit 1:** fix issue with hiding loading message in embedded mode * Original sha: a5d4aaa * Authored by Stacey Gammon <gammon@elastic.co> on 2016-11-28T19:06:49Z **Commit 2:** Fix match as well This chunk of logic only matched on =embed, not =embed=true, which is what the url given by sharing uses. * Original sha: 1f6d7d9 * Authored by Stacey Gammon <gammon@elastic.co> on 2016-11-28T20:51:20Z
stacey-gammon
pushed a commit
that referenced
this pull request
Nov 28, 2016
Backports PR #9235 **Commit 1:** fix issue with hiding loading message in embedded mode * Original sha: a5d4aaa * Authored by Stacey Gammon <gammon@elastic.co> on 2016-11-28T19:06:49Z **Commit 2:** Fix match as well This chunk of logic only matched on =embed, not =embed=true, which is what the url given by sharing uses. * Original sha: 1f6d7d9 * Authored by Stacey Gammon <gammon@elastic.co> on 2016-11-28T20:51:20Z
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Backports PR elastic#9235 **Commit 1:** fix issue with hiding loading message in embedded mode * Original sha: a5d4aaa * Authored by Stacey Gammon <gammon@elastic.co> on 2016-11-28T19:06:49Z **Commit 2:** Fix match as well This chunk of logic only matched on =embed, not =embed=true, which is what the url given by sharing uses. * Original sha: 1f6d7d9 * Authored by Stacey Gammon <gammon@elastic.co> on 2016-11-28T20:51:20Z Former-commit-id: fae9380
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a lingering reference to a class name that was removed in #8970. This uses a class name that exists and removes the 'Give me a moment here...' message.
To repro, just add &embed to the query. You'll see an error (
Uncaught TypeError: Cannot read property 'removeChild' of null(…)) in the javascript console and the loading screen never goes away.