Skip to content

[7.x] [file_upload] move ml Importer classes to file_upload plugin (#91559)#92213

Merged
nreese merged 1 commit intoelastic:7.xfrom
nreese:backport/7.x/pr-91559
Feb 22, 2021
Merged

[7.x] [file_upload] move ml Importer classes to file_upload plugin (#91559)#92213
nreese merged 1 commit intoelastic:7.xfrom
nreese:backport/7.x/pr-91559

Conversation

@nreese
Copy link
Contributor

@nreese nreese commented Feb 22, 2021

Backports the following commits to 7.x:

…#91559)

* [ml] move importer to file_upload plugin

* move file_parse logic into GeoJsonImporter

* move file_parser tests to geojson_importer tests

* rename geo_json_clean_and_validate to geojson_clean_and_validate

* replace file_upload import with Importer.import

* simplify JsonIndexFilePicker props

* tslint

* i18n fixes and tslint fixes

* update functional test to account for change in layer name

* review feedback

* dependency_cache review feedback

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@nreese nreese added the backport This PR is a backport of another PR label Feb 22, 2021
@nreese nreese enabled auto-merge (squash) February 22, 2021 15:49
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fileUpload 189 197 +8
ml 1740 1735 -5
total +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fileUpload 825.2KB 826.0KB +812.0B
maps 2.6MB 2.6MB -282.0B
ml 6.4MB 6.3MB -6.5KB
total -6.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fileUpload 10.4KB 11.5KB +1.1KB
ml 68.0KB 68.3KB +303.0B
total +1.4KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 341fd53 into elastic:7.x Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants