Skip to content

[7.12] [Discover] Always show the "hide missing fields" toggle (#91889) #92212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wylieconlon merged 1 commit into from
Feb 22, 2021
Merged

[7.12] [Discover] Always show the "hide missing fields" toggle (#91889) #92212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/plugins/discover/public/application/components/sidebar/discover_field_search.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,13 @@ describe('DiscoverFieldSearch', () => {
expect(badge.text()).toEqual('0');
});

test('missing switch appears with new fields api', () => {
const component = mountComponent({ ...defaultProps, useNewFieldsApi: true });
const btn = findTestSubject(component, 'toggleFieldFilterButton');
btn.simulate('click');
expect(findTestSubject(component, 'missingSwitch').exists()).toBeTruthy();
});

test('change in filters triggers onChange', () => {
const onChange = jest.fn();
const component = mountComponent({ ...defaultProps, ...{ onChange } });
Expand Down
3 changes: 0 additions & 3 deletions src/plugins/discover/public/application/components/sidebar/discover_field_search.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,9 +232,6 @@ export function DiscoverFieldSearch({ onChange, value, types, useNewFieldsApi }:
};

const footer = () => {
if (useNewFieldsApi) {
return null;
}
return (
<EuiPopoverFooter>
<EuiSwitch
Expand Down