[5.x] Tagcloud #9205
Merged
[5.x] Tagcloud #9205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backports PR #8104 **Commit 1:** tagcloud squashed * Original sha: 1282011 * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-18T21:08:29Z **Commit 2:** ensure tags are not turned upside down * Original sha: 68e09f4 * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T03:43:41Z **Commit 3:** remove unnecessary background * Original sha: dba79b8 * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T03:55:54Z **Commit 4:** add option to hide the label * Original sha: 7f32544 * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T04:08:45Z **Commit 5:** use double-ende slider for font-size selection * Original sha: 00c9ea8 * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T15:26:14Z **Commit 6:** give slider some more space * Original sha: b282084 * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T16:38:55Z **Commit 7:** do not allow 0-sized tags * Original sha: 42bbc39 * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T16:44:26Z **Commit 8:** fix typo * Original sha: f753e1a * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T16:48:24Z **Commit 9:** make capitalization consistent * Original sha: 63101d2 * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T19:47:44Z **Commit 10:** doc checkin * Original sha: fefa40a * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T21:21:17Z **Commit 11:** minor doc edits * Original sha: 84a8fc3 * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T21:34:32Z **Commit 12:** doc build issues * Original sha: cd2374a * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-21T21:46:59Z
Contributor
|
@thomasneirynck not sure why this is failing on 5.x but not on master/5.1 |
Contributor
|
@epixa me neither |
Contributor
|
jenkins, test this |
Contributor
|
Since this build is green and it already got merged into 5.1, I'm going to merge this |
|
I'm still seeing the tag cloud test failures show up periodically on 5.x as well as master: https://kibana-ci.elastic.co/job/elastic+kibana+pull-request+multijob-intake/2168 Should we take them out in the interim until we can figure out what is causing the intermittent failures? |
Contributor
|
this PR addresses test issues: #9194. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tagcloud
Backports PR #8104
Commit 1:
tagcloud squashed
Commit 2:
ensure tags are not turned upside down
Commit 3:
remove unnecessary background
Commit 4:
add option to hide the label
Commit 5:
use double-ende slider for font-size selection
Commit 6:
give slider some more space
Commit 7:
do not allow 0-sized tags
Commit 8:
fix typo
Commit 9:
make capitalization consistent
Commit 10:
doc checkin
Commit 11:
minor doc edits
Commit 12:
doc build issues