Discover: Handle source column differences in embeddable as well #91987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
Feature:Discover
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
31 tasks
majagrubic
approved these changes
Feb 19, 2021
Contributor
majagrubic
left a comment
majagrubic
left a comment
There was a problem hiding this comment.
Tested this with various combinations of _source of fields API for both tables and works as expected.
Maybe we could add a functional test for this, as adding an embeddable of a saved search is quite a common pattern I believe.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Feb 22, 2021
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Feb 22, 2021
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 22, 2021
* master: (36 commits) [Uptime] Thumbnail full screen view steps navigation fix (elastic#91895) Implement ScopedHistory.block (elastic#91099) [Lens] Fix overlowing content on a chart for charts and table (elastic#92006) handle source column differences in embeddable as well (elastic#91987) [Vega] [Map] disable map rotation using right right click / touch rotation gesture (elastic#91996) [Lens] Load indexpatterns list from indexPattern Service (elastic#91984) [coverage] ingest data in parallel (elastic#92074) [Lens] Drag and drop performance improvements (elastic#91641) A few more environment uiFilters fixes (elastic#92044) Enabling Uptime and Dashboard a11y test (elastic#91017) [Security Solution][Detections] Adds more granular validation for nested fields (elastic#92041) [Security Solution] [Detections] add overflow-wrap for description (elastic#91945) [Security Solution] [Detections] do not truncate filename in value list table in modal (elastic#91952) Skip flaky apm test elastic#91673 (elastic#92065) [docker] Default server.name to hostname (elastic#90799) Use documentation link service for snapshot restore (elastic#91596) [Security Solution] Clearing up all jest errors and warnings (elastic#91740) Add `@kbn/analytics` to UI Shared Deps (elastic#91810) [7.12][Telemetry] Add missing fields for security telemetry (elastic#91920) [Security Solution] Adds cypress-pipe (elastic#91550) ...
flash1293
added a commit
that referenced
this pull request
Feb 22, 2021
flash1293
added a commit
that referenced
this pull request
Feb 22, 2021
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #91815
The translation for _source vs document column wasn't called for the embeddable, but with changing settings or legacy saved objects, they can be in an inconsistent state. This PR pulls the same logic inside of the embeddable.
It also moves the call to
getDisplayedColumnswhich is required by the data grid implementation into the datagrid itself so it's not only picked up in main discover, but in the embeddable as well.To test, please consider the full matrix (all 24 combinations) of: