[timelion] Secondary y-axis no longer removes config on first axis #9197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppisljar
added
Feature:Timelion
Contributor
|
Clearly LGTM. Merge it. |
elastic-jasper
added a commit
that referenced
this pull request
Nov 23, 2016
Backports PR #9197 **Commit 1:** fixing timelion Y axis #9114 * Original sha: 54107d6 * Authored by ppisljar <[email protected]> on 2016-11-23T09:37:52Z
epixa
changed the title
epixa
pushed a commit
that referenced
this pull request
Nov 23, 2016
Backports PR #9197 **Commit 1:** fixing timelion Y axis #9114 * Original sha: 54107d6 * Authored by ppisljar <[email protected]> on 2016-11-23T09:37:52Z
elastic-jasper
added a commit
that referenced
this pull request
Nov 23, 2016
Backports PR #9197 **Commit 1:** fixing timelion Y axis #9114 * Original sha: 54107d6 * Authored by ppisljar <[email protected]> on 2016-11-23T09:37:52Z
epixa
pushed a commit
that referenced
this pull request
Nov 23, 2016
…9200) Backports PR #9197 **Commit 1:** fixing timelion Y axis #9114 * Original sha: 54107d6 * Authored by ppisljar <[email protected]> on 2016-11-23T09:37:52Z
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
…lastic#9200) Backports PR elastic#9197 **Commit 1:** fixing timelion Y axis elastic#9114 * Original sha: 54107d6 * Authored by ppisljar <[email protected]> on 2016-11-23T09:37:52Z Former-commit-id: accc45c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9114 where when you set a secondary y axis it would remove all the configuration you set on the first one (so the first one behaves like a default axis)
for example
.static(6000).yaxis(min=5000, position=right), .static(3000).yaxis(2, position=left)
will show both axes on the left (position=right on the first axis will get ignored, as well as the minimum)