Skip to content

[ML] Fix event rate chart annotation position #91899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2021
Merged

[ML] Fix event rate chart annotation position #91899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...ic/application/jobs/new_job/pages/components/charts/event_rate_chart/event_rate_chart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ export const EventRateChart: FC<Props> = ({
<OverlayRange
key={i}
overlayKey={i}
eventRateChartData={eventRateChartData}
start={range.start}
end={range.end}
color={range.color}
Expand Down
31 changes: 9 additions & 22 deletions ...ublic/application/jobs/new_job/pages/components/charts/event_rate_chart/overlay_range.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,29 +7,18 @@

import React, { FC } from 'react';
import { EuiIcon } from '@elastic/eui';
import { RectAnnotation, LineAnnotation, AnnotationDomainTypes } from '@elastic/charts';
import { LineChartPoint } from '../../../../common/chart_loader';
import { RectAnnotation, LineAnnotation, AnnotationDomainTypes, Position } from '@elastic/charts';
import { timeFormatter } from '../../../../../../../../common/util/date_utils';

interface Props {
overlayKey: number;
eventRateChartData: LineChartPoint[];
start: number;
end: number;
color: string;
showMarker?: boolean;
}

export const OverlayRange: FC<Props> = ({
overlayKey,
eventRateChartData,
start,
end,
color,
showMarker = true,
}) => {
const maxHeight = Math.max(...eventRateChartData.map((e) => e.value));

export const OverlayRange: FC<Props> = ({ overlayKey, start, end, color, showMarker = true }) => {
return (
<>
<RectAnnotation
Expand All @@ -41,8 +30,6 @@ export const OverlayRange: FC<Props> = ({
coordinates: {
x0: start,
x1: end,
y0: 0,
y1: maxHeight,
},
},
]}
Expand All @@ -62,16 +49,16 @@ export const OverlayRange: FC<Props> = ({
opacity: 0,
},
}}
markerPosition={Position.Bottom}
hideTooltips={true}
marker={
showMarker ? (
<>
<div style={{ marginLeft: '20px' }}>
<div style={{ textAlign: 'center' }}>
<EuiIcon type="arrowUp" />
</div>
<div style={{ fontWeight: 'normal', color: '#343741' }}>{timeFormatter(start)}</div>
<div>
<div style={{ textAlign: 'center' }}>
<EuiIcon type="arrowUp" />
</div>
</>
<div style={{ fontWeight: 'normal', color: '#343741' }}>{timeFormatter(start)}</div>
</div>
) : undefined
}
/>
Expand Down