Skip to content

[actions] for simplistic email servers, set rejectUnauthorized to false #91760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pmuellr merged 3 commits into from
Mar 1, 2021
Merged

[actions] for simplistic email servers, set rejectUnauthorized to false #91760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7690ddd
[actions] for simplistic email servers, set rejectUnauthorized to false
pmuellr Feb 17, 2021
d976fcd
Merge branch 'master' into actions/email-no-tls
kibanamachine Feb 24, 2021
0debc49
Merge branch 'master' into actions/email-no-tls
kibanamachine Mar 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion x-pack/plugins/actions/server/builtin_action_types/lib/send_email.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ describe('send_email module', () => {
"port": 1025,
"secure": false,
"tls": Object {
"rejectUnauthorized": true,
"rejectUnauthorized": false,
},
},
]
Expand Down Expand Up @@ -187,6 +187,9 @@ describe('send_email module', () => {
"host": "example.com",
"port": 1025,
"secure": true,
"tls": Object {
"rejectUnauthorized": true,
},
},
]
`);
Expand Down
11 changes: 7 additions & 4 deletions x-pack/plugins/actions/server/builtin_action_types/lib/send_email.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,13 @@ export async function sendEmail(logger: Logger, options: SendEmailOptions): Prom
};
transportConfig.proxy = proxySettings.proxyUrl;
transportConfig.headers = proxySettings.proxyHeaders;
} else if (!transportConfig.secure) {
transportConfig.tls = {
rejectUnauthorized,
};
} else if (!transportConfig.secure && user == null && password == null) {
// special case - if secure:false && user:null && password:null set
// rejectUnauthorized false, because simple/test servers that don't even
// authenticate rarely have valid certs; eg cloud proxy, and npm maildev
transportConfig.tls = { rejectUnauthorized: false };
} else {
transportConfig.tls = { rejectUnauthorized };
}
}

Expand Down