Skip to content

[APM] Polish: Update header styles and layout#91093

Merged
dgieselaar merged 6 commits intoelastic:masterfrom
formgeist:apm-update-header-layout
Feb 12, 2021
Merged

[APM] Polish: Update header styles and layout#91093
dgieselaar merged 6 commits intoelastic:masterfrom
formgeist:apm-update-header-layout

Conversation

@formgeist
Copy link
Contributor

@formgeist formgeist commented Feb 11, 2021

Summary

Some minor enhancements to the top headers to separate them from the content area.

Default light theme

screencapture-localhost-5601-ewd-app-apm-services-2021-02-11-10_28_39

screencapture-localhost-5601-ewd-app-apm-services-opbeans-java-overview-2021-02-11-10_30_37

Default dark theme

screencapture-localhost-5601-pnv-s-dark-app-apm-services-2021-02-11-10_48_59

screencapture-localhost-5601-pnv-s-dark-app-apm-services-opbeans-java-overview-2021-02-11-10_49_44

V8 light theme

screencapture-localhost-5601-pnv-app-apm-services-2021-02-11-11_01_23

screencapture-localhost-5601-pnv-app-apm-services-opbeans-java-overview-2021-02-11-11_01_43

@formgeist formgeist added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v8.0.0 release_note:skip Skip the PR/issue when compiling release notes polish v7.12.0 labels Feb 11, 2021
@formgeist formgeist self-assigned this Feb 11, 2021
@formgeist formgeist requested a review from a team February 11, 2021 09:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@formgeist
Copy link
Contributor Author

@elasticmachine merge upstream

@formgeist
Copy link
Contributor Author

@elasticmachine merge upstream

@formgeist
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@ogupte ogupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dgieselaar
Copy link
Contributor

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.2MB 5.2MB +125.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dgieselaar
Copy link
Contributor

There's a UX e2e failure but it seems unrelated to this PR, so I'm merging this one and will try to figure out separately why the failure is happening.

@dgieselaar dgieselaar merged commit b2104ae into elastic:master Feb 12, 2021
dgieselaar pushed a commit to dgieselaar/kibana that referenced this pull request Feb 12, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
dgieselaar added a commit that referenced this pull request Feb 13, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Casper Hübertz <casper@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

polish release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.12.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants