[7.11] [Fleet] Use staging registry for snapshot builds (#90327) #91088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The staging registry is used in Kibana builds which are not built of the master branch or release version. This means, any build ending with `-SNAPSHOT` not the master branch will use the staging registry. Closes elastic#90131 Co-authored-by: Jen Huang <[email protected]> # Conflicts: # x-pack/plugins/fleet/server/services/epm/registry/registry_url.ts
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
To update your PR or re-run it, just comment with: |
EricDavisX
approved these changes
Feb 11, 2021
Contributor
EricDavisX
left a comment
EricDavisX
left a comment
There was a problem hiding this comment.
Thanks SKH - it looks good to me.
Contributor
|
Let us merge it, and regardless of which patch release SNAPSHOT of 7.11.X comes out with it, we will be able to test more easily then - it is helpful. |
Contributor
|
I checked and the latest 7.11.x snapshot on staging has 'staging' registry storage in use, very cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.11: