[Security Solution] Fix paradigm around our container for search strategy query

[XavierM]

Summary

We found a problem around our paradigm in search strategy, the problem was that useCallback does not know when a component is going unmounted, however useEffect does know all the secrets/ life cycle of a component therefore we are taking advantage of it. Also, in the mean time we did simplify our logic to use unsubscribe method instead of using didCancel. We also had a bug that we did not setLoading to false when we get an error from our request.

[elasticmachine]

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

[cnasikas]

LGTM! Some nit comments:

1. For readability reasons I think didCancel.current = false; is better to be along with

abortCtrl.current.abort();
asyncSearch();
refetch.current = asyncSearch;

after the declaration of the asyncSearch function. I think it makes more clear the order of the actions.

Example:

didCancel.current = false;
abortCtrl.current.abort();
asyncSearch();
refetch.current = asyncSearch;

2. Why we setLoading(false); only if !(msg instanceof AbortError)? Shouldn't we do it on any error? If the user aborts the component will stuck on a loading state, right?

3. What do you think about putting searchSubscription$.unsubscribe(); inside the clean-up function of useEffect?

Example:

return () => {
	searchSubscription$.unsubscribe();
	didCancel.current = true;
	abortCtrl.current.abort();
};

[kibanamachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request
• Commit: 60183ed
• Storybooks Preview
• Pipeline Steps (look for red circles / failed steps)
• Interpreting CI Failures

Failed CI Steps

• Check Types
• Execute xpack-securitySolutionCypressFirefox

---

Test Failures

Kibana Pipeline / general / can be marked as favorite.Timelines Creates a timeline by clicking untitled timeline from bottom bar can be marked as favorite

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

AssertionError: Timed out retrying after 60000ms: Expected to find element: `[data-test-subj="timeline-favorite-empty-star"]`, but never found it.
    markAsFavorite@http://localhost:6121/__cypress/tests?p=cypress/integration/timelines/creation.spec.ts:15930:8
    ./cypress/integration/timelines/creation.spec.ts/</</<@http://localhost:6121/__cypress/tests?p=cypress/integration/timelines/creation.spec.ts:15072:24
    setRunnable/runnable.fn@http://elastic:changeme@localhost:6121/__cypress/runner/cypress_runner.js:170493:45
    callFn@http://elastic:changeme@localhost:6121/__cypress/runner/cypress_runner.js:104252:21
    onRunnableRun/<@http://elastic:changeme@localhost:6121/__cypress/runner/cypress_runner.js:176051:28
    finallyHandler@http://elastic:changeme@localhost:6121/__cypress/runner/cypress_runner.js:7163:23
    tryCatcher@http://elastic:changeme@localhost:6121/__cypress/runner/cypress_runner.js:10609:23
    ../../node_modules/bluebird/js/release/promise.js/</module.exports/Promise.prototype._settlePromiseFromHandler@http://elastic:changeme@localhost:6121/__cypress/runner/cypress_runner.js:8544:31
    ../../node_modules/bluebird/js/release/promise.js/</module.exports/Promise.prototype._settlePromise@http://elastic:changeme@localhost:6121/__cypress/runner/cypress_runner.js:8601:18
    ../../node_modules/bluebird/js/release/promise.js/</module.exports/Promise.prototype._settlePromise0@http://elastic:changeme@localhost:6121/__cypress/runner/cypress_runner.js:8646:10
    ../../node_modules/bluebird/js/release/promise.js/</module.exports/Promise.prototype._settlePromises@http://elastic:changeme@localhost:6121/__cypress/runner/cypress_runner.js:8726:18
    _drainQueueStep@http://elastic:changeme@localhost:6121/__cypress/runner/cypress_runner.js:5316:12
    _drainQueue@http://elastic:changeme@localhost:6121/__cypress/runner/cypress_runner.js:5309:24
    ../../node_modules/bluebird/js/release/async.js/</Async.prototype._drainQueues@http://elastic:changeme@localhost:6121/__cypress/runner/cypress_runner.js:5325:16
    Async/this.drainQueues@http://elastic:changeme@localhost:6121/__cypress/runner/cypress_runner.js:5195:14

---

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
securitySolution	7.7MB	7.7MB	+4.4KB

History

• 💛 Build #108557 was flaky 2d295ca

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @XavierM

[kibanamachine]

💚 Backport successful

✅ 7.12 / #92332

Successful backport PRs will be merged automatically after passing CI.