Add original message back to loading screen. #9098
Conversation
|
What prompted this? |
|
As the first load of kibana takes a minute I guess its nice to give some additional feedback to the user about whats happening. visually i would maybe prefer to have it in the blue box under loading kibana but i guess the message is too long to be put there. |
|
I think @epixa referred to "what's prompted the design change"? We already has a loading message for kibana |
|
I was curious what prompted the addition of the text (what this PR is adding). I got the impression in the loading screen redesign that one of the goals was to remove that text. I do think this will help during optimize runs, though. It's really easy to think something is wrong when you see "Loading Kibana" for 60s+. |
|
personally, I would not invest much time in changing the design of the loading screen... sure... change message, text, whatever... but the design here should not be of any priority IMO |
|
@uboness It's already done. The loading screen design is already in 5.x/master, this PR only adds the text below it. |
|
I c... missed it... We have to be more diligent on what we choose to work on... there's so much design work to do, to fix, we have way too few ppl to work on it all. We need to get our priorities right |
|
@uboness I thought (and still think) this is a great investment of my time. This is the first screen anyone sees when they load Kibana, and the original screen sent the (incorrect) impression that we don't care about the little details. This new initial experience is much better and will have a positive impact on every single person who loads up Kibana. 😄 In terms of how much time this took, it took about half a day. @spalger already did much of the work in a Codepen. |
|
This is a pretty huge win for all Kibana users. The loading screen also appears when navigating between certain apps, and the old loading screen looked really unprofessional in the context of the new UI. |
|
ok... no point in debate around this one.. it's done. |
…ins which may need them, by moving them into ui_app.jade.
cjcenizal
force-pushed
the
improvement/loading-screen-bundling-message
branch
from
1775d63 to
30a452e
Compare
|
LGTM |
Backports PR #9098 **Commit 1:** Add original message back to loading screen. Run CSS through autoprefixer. * Original sha: 2f9b817 * Authored by CJ Cenizal <[email protected]> on 2016-11-16T14:06:27Z **Commit 2:** Make kibanaWelcomeView and kibanaWelcomeLogo styles available to plugins which may need them, by moving them into ui_app.jade. * Original sha: 30a452e * Authored by CJ Cenizal <[email protected]> on 2016-11-16T18:24:21Z
Backports PR #9098 **Commit 1:** Add original message back to loading screen. Run CSS through autoprefixer. * Original sha: 2f9b817 * Authored by CJ Cenizal <[email protected]> on 2016-11-16T14:06:27Z **Commit 2:** Make kibanaWelcomeView and kibanaWelcomeLogo styles available to plugins which may need them, by moving them into ui_app.jade. * Original sha: 30a452e * Authored by CJ Cenizal <[email protected]> on 2016-11-16T18:24:21Z
Backports PR elastic#9098 **Commit 1:** Add original message back to loading screen. Run CSS through autoprefixer. * Original sha: 2f9b817 * Authored by CJ Cenizal <[email protected]> on 2016-11-16T14:06:27Z **Commit 2:** Make kibanaWelcomeView and kibanaWelcomeLogo styles available to plugins which may need them, by moving them into ui_app.jade. * Original sha: 30a452e * Authored by CJ Cenizal <[email protected]> on 2016-11-16T18:24:21Z Former-commit-id: d58ba76
4 participants
Let's keep traditions alive! Because bundling can take so long, this message will give users some reassurance that, yes, it's really supposed to take awhile and yes, everything will be OK.