Merged
Conversation
flash1293
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
wylieconlon
approved these changes
Feb 9, 2021
Contributor
wylieconlon
left a comment
wylieconlon
left a comment
There was a problem hiding this comment.
Did not run the change, but looks good.
| }, | ||
| source: 'esaggs', | ||
| sourceParams: { | ||
| appliedTimeRange: undefined, |
Contributor
There was a problem hiding this comment.
Looks like this is added because count is handled in a unique way, but most metrics have this?
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Feb 11, 2021
flash1293
added a commit
that referenced
this pull request
Feb 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
TabbedAggResponseWriterturning the response from Elasticsearch into a datatable is inferring thetypeof the datatable column using the type of the underlying field. While this is a good strategy for most aggregations, it doesn't work for cardinality - a string field will produce a number value as well for this aggregation.This PR adds a way to specify the expected column type if it diverges from the field type.
Context of this is #89300 which is using this value to determine how to align text in a data table.