Skip to content

[Grok Debugger] Changed test to wait for grok debugger container to exist to fix test flakiness #90543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 9, 2021
Merged

[Grok Debugger] Changed test to wait for grok debugger container to exist to fix test flakiness #90543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f571291
Changed the retry to a wait for condition which will keep trying for …
Feb 6, 2021
ff7f2dd
Added .only to be able to run the test repeatedly because group 13 is…
Feb 6, 2021
c81c0f3
Added to group 11 because 13 is not in flaky test runner. Will revert…
Feb 6, 2021
5b0ce65
Merge branch 'master' into Fixed_Grok_Debugger_Flaky_Test
kibanamachine Feb 8, 2021
00896fd
Reverted change back to group 13 and removed the comment for the flak…
Feb 9, 2021
0df1535
Merge branch 'Fixed_Grok_Debugger_Flaky_Test' of github.com:cuff-link…
Feb 9, 2021
70de633
Merge branch 'master' into Fixed_Grok_Debugger_Flaky_Test
kibanamachine Feb 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/grokdebugger/public/components/grok_debugger/grok_debugger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ export class GrokDebuggerComponent extends React.Component {
<EuiPageBody>
<EuiPageContent>
<EuiPageContentBody>
<EuiForm className="grokdebugger-container" data-test-subj="grokDebugger">
<EuiForm className="grokdebugger-container" data-test-subj="grokDebuggerContainer">
<EventInput value={this.state.rawEvent} onChange={this.onRawEventChange} />
<PatternInput value={this.state.pattern} onChange={this.onPatternChange} />
<EuiSpacer />
Expand Down
3 changes: 1 addition & 2 deletions x-pack/test/functional/apps/grok_debugger/grok_debugger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ export default function ({ getService, getPageObjects }) {

const PageObjects = getPageObjects(['grokDebugger']);

// FLAKY: https://github.com/elastic/kibana/issues/84440
describe.skip('grok debugger app', function () {
describe('grok debugger app', function () {
this.tags('includeFirefox');
before(async () => {
await esArchiver.load('empty_kibana');
Expand Down
8 changes: 3 additions & 5 deletions x-pack/test/functional/services/grok_debugger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export function GrokDebuggerProvider({ getService }) {
const retry = getService('retry');

// test subject selectors
const SUBJ_CONTAINER = 'grokDebugger';
const SUBJ_CONTAINER = 'grokDebuggerContainer';

const SUBJ_UI_ACE_EVENT_INPUT = `${SUBJ_CONTAINER} > aceEventInput > codeEditorContainer`;
const SUBJ_UI_ACE_PATTERN_INPUT = `${SUBJ_CONTAINER} > acePatternInput > codeEditorContainer`;
Expand Down Expand Up @@ -49,10 +49,8 @@ export function GrokDebuggerProvider({ getService }) {
}

async assertExists() {
await retry.try(async () => {
if (!(await testSubjects.exists(SUBJ_CONTAINER))) {
throw new Error('Expected to find the grok debugger');
}
await retry.waitFor('Grok Debugger to exist', async () => {
return await testSubjects.exists(SUBJ_CONTAINER);
});
}

Expand Down