[Tabify] Add meta option to include top-level underscored field values #90535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
zDeprecated Feature:Reporting
16 tasks
Member
Author
|
@elasticmachine merge upstream |
Contributor
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
Member
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Feb 9, 2021
elastic#90535) Co-authored-by: Kibana Machine <[email protected]>
tsullivan
added a commit
that referenced
this pull request
Feb 9, 2021
#90535) (#90814) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an option to the TabifyDocsOptions interface that tells tabifyDocs to add the top-level "underscore" fields to the tabified data:
Discover allows a user to add these fields as columns, so tabifyDocs should know about them.
Checklist
Delete any items that are not applicable to this PR.
For maintainers