[Search Sessions] Use sync config #90138

lizozom · 2021-02-03T10:45:05Z

Summary

Depends on #89570
Following #88981, use sync configs in data_enhanced

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

…d state

… session

…a into sessions/save-all-sessions

…-all-sessions

…a into sessions/save-all-sessions

…-all-sessions

Fix get search status tests

…-all-sessions

add comments

…-all-sessions

…a into sessions/save-all-sessions

…sync-config

lizozom · 2021-02-04T12:40:43Z

@elasticmachine merge upstream

…into sessions/use-sync-config

Dosant

lgtm, code review only

x-pack/plugins/data_enhanced/server/search/session/session_service.ts

…sync-config

kibanamachine · 2021-02-05T19:43:21Z

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

💚 Build #103786 succeeded e78f7e2
💔 Build #103620 failed c53310a
💔 Build #103617 failed 8e1dcf2
💚 Build #103343 succeeded f0e4281

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

tsullivan

LGTM! Reviewed the code changes

@lukasolson

* Search Sessions: Unskip Flaky Functional Test * Save all search sessions and then manage them based on their persisted state * Get default search session expiration from config * randomize sleep time * fix test * fix test * Make sure we poll, and dont persist, searches not in the context of a session * Added keepalive unit tests * fix ts * code review @lukasolson * ts * More tests, rename onScreenTimeout to completedTimeout * lint * lint * Delete async seaches * Support saved object pagination Fix get search status tests * better PersistedSearchSessionSavedObjectAttributes ts * test titles * Remove runAt from monitoring task Increase testing trackingInterval (caused bug) * support workload histograms that take into account overdue tasks * Update touched when changing session status to complete \ error * removed test * Updated management test data * Rename configs * delete tap first add comments * Use sync config in data-enhanced plugin * fix merge * fix merge * ts * code review Co-authored-by: Timothy Sullivan <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Anton Dosov <[email protected]> Co-authored-by: Gidi Meir Morris <[email protected]>

@lukasolson

* Search Sessions: Unskip Flaky Functional Test * Save all search sessions and then manage them based on their persisted state * Get default search session expiration from config * randomize sleep time * fix test * fix test * Make sure we poll, and dont persist, searches not in the context of a session * Added keepalive unit tests * fix ts * code review @lukasolson * ts * More tests, rename onScreenTimeout to completedTimeout * lint * lint * Delete async seaches * Support saved object pagination Fix get search status tests * better PersistedSearchSessionSavedObjectAttributes ts * test titles * Remove runAt from monitoring task Increase testing trackingInterval (caused bug) * support workload histograms that take into account overdue tasks * Update touched when changing session status to complete \ error * removed test * Updated management test data * Rename configs * delete tap first add comments * Use sync config in data-enhanced plugin * fix merge * fix merge * ts * code review Co-authored-by: Timothy Sullivan <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Anton Dosov <[email protected]> Co-authored-by: Gidi Meir Morris <[email protected]> Co-authored-by: Timothy Sullivan <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Anton Dosov <[email protected]> Co-authored-by: Gidi Meir Morris <[email protected]>

* master: (55 commits) [APM-UI][E2E] use githubNotify step (elastic#90514) [APM] Export ProcessorEvent type (elastic#90540) [Lens] Retain column config (elastic#90048) [Data Table] Add unit tests (elastic#90173) Migrate most plugins to synchronous lifecycle (elastic#89562) skip flaky suite (elastic#90555) skip flaky suite (elastic#64473) [actions] improve email action doc (elastic#90020) [Fleet] Support Fleet server system indices (elastic#89372) skip flaky suite (elastic#90552) Bump immer dependencies (elastic#90267) Unrevert "Migrations v2: don't auto-create indices + FTR/esArchiver support (elastic#85778)" (elastic#89992) [Search Sessions] Use sync config (elastic#90138) chore(NA): add safe guard to remove bazelisk from yarn global at bootstrap (elastic#90538) [test] Await retry.waitFor (elastic#90456) chore(NA): integrate build buddy with our bazel setup and remote cache for ci (elastic#90116) Skip failing suite (elastic#90526) [Fleet] Fix incorrect conversion of string to numeric values in agent YAML (elastic#90371) [Docs] Update reporting troubleshooting for arm rhel/centos (elastic#90385) chore(NA): build bazel projects all at once in the distributable build process (elastic#90328) ...

tsullivan and others added 30 commits January 26, 2021 14:41

Search Sessions: Unskip Flaky Functional Test

03f413a

Merge branch 'master' into flaky/search-sessions

2e09f56

Save all search sessions and then manage them based on their persiste…

cb1de74

…d state

Get default search session expiration from config

2b3b90e

randomize sleep time

cd23cef

fix test

5f21181

fix test

cdcf562

Merge branch 'master' into sessions/save-all-sessions

bdbc748

Make sure we poll, and dont persist, searches not in the context of a…

667c9d3

… session

Merge branch 'sessions/save-all-sessions' of github.com:lizozom/kiban…

867f1f4

…a into sessions/save-all-sessions

Merge branch 'master' of github.com:elastic/kibana into sessions/save…

51545ae

…-all-sessions

Added keepalive unit tests

763746b

Merge branch 'master' into sessions/save-all-sessions

bbf85c5

fix ts

01f292d

Merge branch 'master' into flaky/search-sessions

7a85729

Merge branch 'master' of github.com:elastic/kibana into sessions/save…

46cdf7f

…-all-sessions

Merge branch 'sessions/save-all-sessions' of github.com:lizozom/kiban…

393d800

…a into sessions/save-all-sessions

code review @lukasolson

2d75b96

Merge branch 'master' of github.com:elastic/kibana into sessions/save…

13691e6

…-all-sessions

ts

1cd21fd

More tests, rename onScreenTimeout to completedTimeout

a9cc263

lint

bfcbdb2

lint

9b914f6

Merge branch 'master' into flaky/search-sessions

ddb86a7

Delete async seaches

7ab767d

Support saved object pagination

d924604

Fix get search status tests

Merge branch 'master' of github.com:elastic/kibana into sessions/save…

11f429e

…-all-sessions

better PersistedSearchSessionSavedObjectAttributes ts

48a90fb

test titles

de99c73

Merge branch 'master' of github.com:elastic/kibana into sessions/save…

1bad580

…-all-sessions

Liza K added 4 commits February 3, 2021 12:02

delete tap first

2bd7e2b

add comments

Merge branch 'master' of github.com:elastic/kibana into sessions/save…

cf45bb3

…-all-sessions

Merge branch 'sessions/save-all-sessions' of github.com:lizozom/kiban…

19fa7e1

…a into sessions/save-all-sessions

Use sync config in data-enhanced plugin

f0e4281

lizozom added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 NeededFor:AppServices labels Feb 3, 2021

lizozom self-assigned this Feb 3, 2021

lizozom requested a review from tsullivan February 3, 2021 13:01

lizozom mentioned this pull request Feb 3, 2021

[Search Sessions] Save all sessions, with persisted flag #89570

Merged

9 tasks

Liza K added 3 commits February 3, 2021 23:33

Merge branch 'master' of github.com:elastic/kibana into sessions/use-…

8e1dcf2

…sync-config

fix merge

dbfd580

fix merge

c53310a

lizozom marked this pull request as ready for review February 3, 2021 21:41

lizozom requested a review from a team as a code owner February 3, 2021 21:41

kibanamachine and others added 3 commits February 4, 2021 07:40

Merge branch 'master' into sessions/use-sync-config

a8325f7

ts

7cee454

Merge branch 'sessions/use-sync-config' of github.com:lizozom/kibana …

e78f7e2

…into sessions/use-sync-config

Dosant approved these changes Feb 5, 2021

View reviewed changes

x-pack/plugins/data_enhanced/server/search/session/session_service.ts Outdated Show resolved Hide resolved

Liza K added 2 commits February 5, 2021 19:54

code review

336f056

Merge branch 'master' of github.com:elastic/kibana into sessions/use-…

3ff4185

…sync-config

tsullivan approved these changes Feb 5, 2021

View reviewed changes

lizozom merged commit 826a1ec into elastic:master Feb 6, 2021

lizozom mentioned this pull request Feb 6, 2021

[7.x] [Search Sessions] Use sync config (#90138) #90549

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Search Sessions] Use sync config #90138

[Search Sessions] Use sync config #90138

Uh oh!

lizozom commented Feb 3, 2021

Uh oh!

lizozom commented Feb 4, 2021

Uh oh!

Dosant left a comment

Uh oh!

Uh oh!

kibanamachine commented Feb 5, 2021

Uh oh!

tsullivan left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[Search Sessions] Use sync config #90138

[Search Sessions] Use sync config #90138

Uh oh!

Conversation

lizozom commented Feb 3, 2021

Summary

Checklist

For maintainers

Uh oh!

lizozom commented Feb 4, 2021

Uh oh!

Dosant left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kibanamachine commented Feb 5, 2021

💚 Build Succeeded

Metrics [docs]

History

Uh oh!

tsullivan left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants