Skip to content

[Monitoring] Fixed alert imports #89935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2021
Merged

[Monitoring] Fixed alert imports #89935

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 11 additions & 15 deletions x-pack/plugins/monitoring/public/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,14 @@ import {
ALERT_DETAILS,
} from '../common/constants';

import { createCpuUsageAlertType } from './alerts/cpu_usage_alert';
import { createMissingMonitoringDataAlertType } from './alerts/missing_monitoring_data_alert';
import { createLegacyAlertTypes } from './alerts/legacy_alert';
import { createDiskUsageAlertType } from './alerts/disk_usage_alert';
import { createThreadPoolRejectionsAlertType } from './alerts/thread_pool_rejections_alert';
import { createMemoryUsageAlertType } from './alerts/memory_usage_alert';
import { createCCRReadExceptionsAlertType } from './alerts/ccr_read_exceptions_alert';

interface MonitoringSetupPluginDependencies {
home?: HomePublicPluginSetup;
cloud?: { isCloudEnabled: boolean };
Expand Down Expand Up @@ -72,7 +80,7 @@ export class MonitoringPlugin
});
}

await this.registerAlertsAsync(plugins);
this.registerAlerts(plugins);

const app: App = {
id,
Expand Down Expand Up @@ -135,19 +143,7 @@ export class MonitoringPlugin
];
}

private registerAlertsAsync = async (plugins: MonitoringSetupPluginDependencies) => {
const { createCpuUsageAlertType } = await import('./alerts/cpu_usage_alert');
const { createMissingMonitoringDataAlertType } = await import(
'./alerts/missing_monitoring_data_alert'
);
const { createLegacyAlertTypes } = await import('./alerts/legacy_alert');
const { createDiskUsageAlertType } = await import('./alerts/disk_usage_alert');
const { createThreadPoolRejectionsAlertType } = await import(
'./alerts/thread_pool_rejections_alert'
);
const { createMemoryUsageAlertType } = await import('./alerts/memory_usage_alert');
const { createCCRReadExceptionsAlertType } = await import('./alerts/ccr_read_exceptions_alert');

private registerAlerts(plugins: MonitoringSetupPluginDependencies) {
const {
triggersActionsUi: { alertTypeRegistry },
} = plugins;
Expand All @@ -172,5 +168,5 @@ export class MonitoringPlugin
for (const legacyAlertType of legacyAlertTypes) {
alertTypeRegistry.register(legacyAlertType);
}
};
}
}