Do not crash for warning and error nodes without http published address#8982
Closed
czertbytes wants to merge 1 commit intoelastic:masterfrom
czertbytes:nodes-without-publish-address
Closed
Do not crash for warning and error nodes without http published address#8982czertbytes wants to merge 1 commit intoelastic:masterfrom czertbytes:nodes-without-publish-address
czertbytes wants to merge 1 commit intoelastic:masterfrom
czertbytes:nodes-without-publish-address
Conversation
Contributor
|
Can one of the admins verify this patch? |
Contributor
|
jenkins, test this |
Contributor
|
This will also cause errors on elasticsearch/kibana version mismatches. |
Contributor
|
@czertbytes the method getHumanizedNodeNames would need the same check, it won't necessarily be coming from warningNodes. Would you be up for adding that? |
Contributor
|
@czertbytes Thanks for the fix! I added a commit on top of yours in a new PR at #9181, closing this one now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our ES setup contains nodes with different roles (master, data and client) where only client nodes have enabled http (http address). Master and data nodes expose only transport address. ES configuration is based on this design https://github.com/pires/kubernetes-elasticsearch-cluster .
After connecting Kibana to this ES cluster we are getting error
Elasticsearch plugin is redwith error message for elasticsearch pluginCannot read property 'publish_address' of undefinedcaused by parsing node details (ES version) for master and data nodes which do not have given property.This PR is fixing problem of accessing not existing property in node with default value to empty string.