Skip to content

Remove UI filters from UI #89793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Feb 4, 2021
Merged

Remove UI filters from UI #89793

merged 15 commits into from
Feb 4, 2021

Conversation

@smith
Copy link
Contributor

@smith smith commented Jan 29, 2021 •
edited
Loading

  • Remove the UI filters components from the UI in APM.
  • Remove unused UI filters API endpoints.
  • Move UI filters components into UX directories
  • Move correlations button from public/components/app/TraceOverview/index.tsx to top bar (see Transactions drill-down page re-design apm#358 (comment))
  • Convert public/components/app/RumDashboard/LocalUIFilters/TransactionTypeFilter/index.tsx to the dropdown for transactions overview. See above
  • Decrease margin on search bar to match EuiPage

Screenshot of new transaction type select and placement of correlations button:

image

References #84526.

@smith smith mentioned this pull request Feb 2, 2021
Closed
8 tasks
@smith smith marked this pull request as ready for review February 2, 2021 21:07
@smith smith requested review from a team as code owners February 2, 2021 21:07
@botelastic botelastic bot added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Feb 2, 2021
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 2, 2021

Pinging @elastic/uptime (Team:uptime)

@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 2, 2021

Pinging @elastic/apm-ui (Team:apm)

sorenlouv
sorenlouv reviewed Feb 2, 2021
View reviewed changes
x-pack/plugins/apm/public/components/shared/transaction_type_select.tsx Outdated
Comment on lines 33 to 40
const newLocation = {
...history.location,
search: fromQuery({
...toQuery(history.location.search),
transactionType: selectedTransactionType,
}),
};
history.push(newLocation);
Copy link
Member

@sorenlouv sorenlouv Feb 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a helper for making this a little easier:

Suggested change
const newLocation = {
...history.location,
search: fromQuery({
...toQuery(history.location.search),
transactionType: selectedTransactionType,
}),
};
history.push(newLocation);
urlHelpers.push(history, { transactionType: selectedTransactionType });

Copy link
Contributor Author

@smith smith Feb 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. I copied this from the ui filters so this is much nicer.

sorenlouv
sorenlouv approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Should we attempt to remove the projections in a follow-up PR?

@smith
Copy link
Contributor Author

smith commented Feb 3, 2021

lgtm! Should we attempt to remove the projections in a follow-up PR?

Yes. I updated some of the items on #84526 so that should get done.

justinkambic
justinkambic approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes seem fine, smoke test was fine. LGTM

@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 4, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1737 1736 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.2MB 5.2MB -4.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit 85e92b5 into elastic:master Feb 4, 2021
@smith smith deleted the nls/ui-filters-ui branch February 4, 2021 19:29
@smith smith mentioned this pull request Feb 4, 2021
Merged
smith added a commit to smith/kibana that referenced this pull request Feb 4, 2021
@smith
Remove UI filters from UI (elastic#89793)
a927d58 
* Start moving some stuff

* Move some stuff around

* more

* Transactions label

* some snake casing

* i18n fix

* Remove unused ui filters endpoints

* Updates to select

* remove projections

* Use urlHelpers.push

* License change
smith added a commit that referenced this pull request Feb 4, 2021
@smith
Remove UI filters from UI (#89793) (#90321)
4e94a58
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 4, 2021
@gmmorris
Merge branch 'master' into task-manager/support-limited-concurrency
5190abf 
* master: (244 commits)
  [maps] Top hits per entity--change to title to use recent, minor edits (elastic#89254)
  [DOCS] Update installation details (elastic#90354)
  RFC for automatically generated typescript API documentation for every plugins public services, types, and functionality (elastic#86704)
  Elastic Maps Server config is `host` not `hostname` (elastic#90234)
  Use doc link services in index pattern management (elastic#89937)
  [Fleet] Managed Agent Policy (elastic#88688)
  [Workplace Search] Fix Source Settings bug  (elastic#90242)
  [Enterprise Search] Refactor MockRouter test helper to not store payload (elastic#90206)
  Use doc link service in more Stack Monitoring pages (elastic#89050)
  [App Search] Relevance Tuning logic - actions and selectors only, no listeners (elastic#89313)
  Remove UI filters from UI (elastic#89793)
  Use newfeed.service config for all newsfeeds (elastic#90252)
  skip flaky suite (elastic#85086)
  Add readme to geo containment alert covering test alert setup (elastic#89625)
  [APM] Enabling yesterday option when 24 hours is selected (elastic#90017)
  Test user for maps tests under import geoJSON tests (elastic#86015)
  [Lens] Hide column in table (elastic#88680)
  [Security Solution][Detections] Reduce detection engine reliance on _source (elastic#89371)
  [Discover] Minor cleanup (elastic#90260)
  [Search Session][Management] Rename "cancel" button and delete "Reload" button (elastic#90015)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

@justinkambic justinkambic justinkambic approved these changes

Assignees

No one assigned

Labels

release_note:enhancement Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.12.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@smith @elasticmachine @kibanamachine @sorenlouv @justinkambic