Migrate indexPatternManagement to TS project ref #89759

TinaHeiligers · 2021-01-29T17:38:48Z

Summary

Partially addresses #80508 (App services section)

tsc compiler performance with running node --max-old-space-size=4096 ./node_modules/.bin/tsc -p tsconfig.json --extendedDiagnostics --noEmit

** Before
Files: 3044
Lines: 336735

** After
Files: 2574
Lines: 315345

elasticmachine · 2021-01-29T19:16:32Z

Pinging @elastic/kibana-app-services (Team:AppServices)

TinaHeiligers · 2021-01-29T19:18:06Z

cc @elastic/kibana-app-services

kibanamachine · 2021-02-01T19:21:53Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: c09eb74
Flaky suites:
- xpack-accessibility

Test Failures

Kibana Pipeline / general / X-Pack Accessibility Tests.x-pack/test/accessibility/apps/uptime·ts.uptime overview alert popover controls

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:01:09]         └-: uptime
[00:01:09]           └-> "before all" hook
[00:01:09]           └-> "before all" hook
[00:01:09]             │ info [uptime/blank] Loading "mappings.json"
[00:01:09]             │ info [uptime/blank] Loading "data.json"
[00:01:09]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1612200041760307057] [heartbeat-8-generated-test] creating index, cause [api], templates [], shards [1]/[1]
[00:01:09]             │ info [uptime/blank] Created index "heartbeat-8-generated-test"
[00:01:09]             │ debg [uptime/blank] "heartbeat-8-generated-test" settings undefined
[00:01:10]           └-> overview page
[00:01:10]             └-> "before each" hook: global before each
[00:01:10]             └-> "before each" hook
[00:01:10]               │ debg TestSubjects.exists(uptimeSettingsToOverviewLink)
[00:01:10]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="uptimeSettingsToOverviewLink"]') with timeout=0
[00:01:10]               │ debg --- retry.tryForTime error: [data-test-subj="uptimeSettingsToOverviewLink"] is not displayed
[00:01:11]               │ debg navigating to uptime url: http://localhost:61121/app/uptime
[00:01:11]               │ debg navigate to: http://localhost:61121/app/uptime
[00:01:11]               │ debg browser[INFO] http://localhost:61121/app/uptime?_t=1612201930240 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:01:11]               │
[00:01:11]               │ debg browser[INFO] http://localhost:61121/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:01:11]               │ debg ... sleep(700) start
[00:01:12]               │ debg ... sleep(700) end
[00:01:12]               │ debg returned from get, calling refresh
[00:01:12]               │ debg browser[INFO] http://localhost:61121/app/uptime?_t=1612201930240 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:01:12]               │
[00:01:12]               │ debg browser[INFO] http://localhost:61121/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:01:12]               │ debg currentUrl = http://localhost:61121/app/uptime
[00:01:12]               │          appUrl = http://localhost:61121/app/uptime
[00:01:12]               │ debg TestSubjects.find(kibanaChrome)
[00:01:12]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:01:13]               │ debg ... sleep(501) start
[00:01:13]               │ debg ... sleep(501) end
[00:01:13]               │ debg in navigateTo url = http://localhost:61121/app/uptime
[00:01:13]               │ debg TestSubjects.exists(statusPageContainer)
[00:01:13]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:01:16]               │ERROR browser[SEVERE] http://localhost:61121/40017/bundles/plugin/uptime/uptime.chunk.1.js 2:18780 "API /api/uptime/monitor/list is not returning expected response, Invalid value \"undefined\" supplied to \"summaries.state.summaryPings.tls.server.x509.issuer.distinguished_name\",Invalid value \"undefined\" supplied to \"summaries.state.summaryPings.tls.server.x509.subject.distinguished_name\",Invalid value \"undefined\" supplied to \"summaries.state.summaryPings.tls.server.x509.serial_number\",Invalid value \"undefined\" supplied to \"summaries.state.summaryPings.tls.server.x509.public_key_algorithm\",Invalid value \"undefined\" supplied to \"summaries.state.summaryPings.tls.server.x509.signature_algorithm\",Invalid value \"undefined\" supplied to \"summaries.state.summaryPings.tls.server.x509.not_after\",Invalid value \"undefined\" supplied to \"summaries.state.summaryPings.tls.server.x509.not_before\" for response" Object
[00:01:16]               │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:01:16]               │ debg isGlobalLoadingIndicatorVisible
[00:01:16]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:01:16]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:01:18]               │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:01:18]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:01:18]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:01:18]               │ debg TestSubjects.exists(uptimeOverviewPage)
[00:01:18]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="uptimeOverviewPage"]') with timeout=2000
[00:01:19]             └- ✓ pass  (530ms) "uptime overview page"
[00:01:19]           └-> overview page with expanded monitor detail
[00:01:19]             └-> "before each" hook: global before each
[00:01:19]             └-> "before each" hook
[00:01:19]               │ debg TestSubjects.exists(uptimeSettingsToOverviewLink)
[00:01:19]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="uptimeSettingsToOverviewLink"]') with timeout=0
[00:01:19]               │ debg TestSubjects.click(uptimeSettingsToOverviewLink)
[00:01:19]               │ debg Find.clickByCssSelector('[data-test-subj="uptimeSettingsToOverviewLink"]') with timeout=10000
[00:01:19]               │ debg Find.findByCssSelector('[data-test-subj="uptimeSettingsToOverviewLink"]') with timeout=10000
[00:01:19]               │ debg isGlobalLoadingIndicatorVisible
[00:01:19]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:01:19]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:01:21]               │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:01:21]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:01:21]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:01:21]               │ debg TestSubjects.exists(uptimeOverviewPage)
[00:01:21]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="uptimeOverviewPage"]') with timeout=2000
[00:01:21]             │ debg TestSubjects.click(xpack.uptime.monitorList.a11yTestMonitor.expandMonitorDetail)
[00:01:21]             │ debg Find.clickByCssSelector('[data-test-subj="xpack.uptime.monitorList.a11yTestMonitor.expandMonitorDetail"]') with timeout=10000
[00:01:21]             │ debg Find.findByCssSelector('[data-test-subj="xpack.uptime.monitorList.a11yTestMonitor.expandMonitorDetail"]') with timeout=10000
[00:01:21]             │ debg TestSubjects.click(xpack.uptime.monitorList.actionsPopover.a11yTestMonitor)
[00:01:21]             │ debg Find.clickByCssSelector('[data-test-subj="xpack.uptime.monitorList.actionsPopover.a11yTestMonitor"]') with timeout=10000
[00:01:21]             │ debg Find.findByCssSelector('[data-test-subj="xpack.uptime.monitorList.actionsPopover.a11yTestMonitor"]') with timeout=10000
[00:01:22]             └- ✓ pass  (687ms) "uptime overview page with expanded monitor detail"
[00:01:22]           └-> overview alert popover controls
[00:01:22]             └-> "before each" hook: global before each
[00:01:22]             └-> "before each" hook
[00:01:22]               │ debg TestSubjects.exists(uptimeSettingsToOverviewLink)
[00:01:22]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="uptimeSettingsToOverviewLink"]') with timeout=0
[00:01:22]               │ debg TestSubjects.click(uptimeSettingsToOverviewLink)
[00:01:22]               │ debg Find.clickByCssSelector('[data-test-subj="uptimeSettingsToOverviewLink"]') with timeout=10000
[00:01:22]               │ debg Find.findByCssSelector('[data-test-subj="uptimeSettingsToOverviewLink"]') with timeout=10000
[00:01:22]               │ debg isGlobalLoadingIndicatorVisible
[00:01:22]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:01:22]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:01:24]               │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:01:24]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:01:24]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:01:24]               │ debg TestSubjects.exists(uptimeOverviewPage)
[00:01:24]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="uptimeOverviewPage"]') with timeout=2000
[00:01:24]             │ debg TestSubjects.click(xpack.uptime.alertsPopover.toggleButton)
[00:01:24]             │ debg Find.clickByCssSelector('[data-test-subj="xpack.uptime.alertsPopover.toggleButton"]') with timeout=10000
[00:01:24]             │ debg Find.findByCssSelector('[data-test-subj="xpack.uptime.alertsPopover.toggleButton"]') with timeout=10000
[00:01:25]             │ info Taking screenshot "/dev/shm/workspace/parallel/12/kibana/x-pack/test/functional/screenshots/failure/uptime overview alert popover controls.png"
[00:01:25]             │ info Current URL is: http://localhost:61121/app/uptime
[00:01:25]             │ info Saving page source to: /dev/shm/workspace/parallel/12/kibana/x-pack/test/functional/failure_debug/html/uptime overview alert popover controls.html
[00:01:25]             └- ✖ fail: uptime overview alert popover controls
[00:01:25]             │      Error: a11y report:
[00:01:25]             │ 
[00:01:25]             │ VIOLATION
[00:01:25]             │   [aria-hidden-focus]: Ensures aria-hidden elements do not contain focusable elements
[00:01:25]             │     Help: https://dequeuniversity.com/rules/axe/4.0/aria-hidden-focus?application=axeAPI
[00:01:25]             │     Elements:
[00:01:25]             │       - #kibana-body
[00:01:25]             │       - div[data-focus-guard="true"][data-aria-hidden="true"][aria-hidden="true"]:nth-child(1)
[00:01:25]             │       - div[data-focus-guard="true"][data-aria-hidden="true"][aria-hidden="true"]:nth-child(2)
[00:01:25]             │       - div[data-focus-guard="true"][data-aria-hidden="true"][aria-hidden="true"]:nth-child(4)
[00:01:25]             │       at Accessibility.testAxeReport (/dev/shm/workspace/parallel/12/kibana/test/accessibility/services/a11y/a11y.ts:76:15)
[00:01:25]             │       at Accessibility.testAppSnapshot (/dev/shm/workspace/parallel/12/kibana/test/accessibility/services/a11y/a11y.ts:49:18)
[00:01:25]             │       at runMicrotasks (<anonymous>)
[00:01:25]             │       at processTicksAndRejections (internal/process/task_queues.js:93:5)
[00:01:25]             │       at Context.<anonymous> (test/accessibility/apps/uptime.ts:61:7)
[00:01:25]             │       at Object.apply (/dev/shm/workspace/parallel/12/kibana/packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16)
[00:01:25]             │ 
[00:01:25]             │

Stack Trace

Error: a11y report:

VIOLATION
  [aria-hidden-focus]: Ensures aria-hidden elements do not contain focusable elements
    Help: https://dequeuniversity.com/rules/axe/4.0/aria-hidden-focus?application=axeAPI
    Elements:
      - #kibana-body
      - div[data-focus-guard="true"][data-aria-hidden="true"][aria-hidden="true"]:nth-child(1)
      - div[data-focus-guard="true"][data-aria-hidden="true"][aria-hidden="true"]:nth-child(2)
      - div[data-focus-guard="true"][data-aria-hidden="true"][aria-hidden="true"]:nth-child(4)
    at Accessibility.testAxeReport (/dev/shm/workspace/parallel/12/kibana/test/accessibility/services/a11y/a11y.ts:76:15)
    at Accessibility.testAppSnapshot (/dev/shm/workspace/parallel/12/kibana/test/accessibility/services/a11y/a11y.ts:49:18)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at Context.<anonymous> (test/accessibility/apps/uptime.ts:61:7)
    at Object.apply (/dev/shm/workspace/parallel/12/kibana/packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16)

Metrics [docs]

✅ unchanged

History

💚 Build #102454 succeeded 11f98f9
💚 Build #102234 succeeded 954c10d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

TinaHeiligers added 2 commits January 29, 2021 10:27

Adds tsconfig.json to index_pattern_management

a7f2857

Converts indexPatternManagement to a TS project ref

954c10d

TinaHeiligers added chore v8.0.0 Team:AppServices release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Jan 29, 2021

TinaHeiligers mentioned this pull request Jan 29, 2021

[Meta] Migrate Kibana plugins to TS project references #80508

Closed

TinaHeiligers changed the title ~~Adds tsconfig.json to index_pattern_management~~ Migrate indexPatternManagement to TS project ref Jan 29, 2021

TinaHeiligers marked this pull request as ready for review January 29, 2021 19:16

TinaHeiligers requested a review from mshustov January 29, 2021 19:16

This was referenced Jan 30, 2021

[Meta] Migrate plugins to TS references for es_ui CODEOWNERS plugins #89321

Closed

[ML] Migrate ML plugin to TS project references #89270

Closed

Merge branch 'master' into ts-project-refs/index_pattern_management

11f98f9

mattkime approved these changes Feb 1, 2021

View reviewed changes

Merge branch 'master' into ts-project-refs/index_pattern_management

c09eb74

TinaHeiligers merged commit 5c96da1 into elastic:master Feb 1, 2021

TinaHeiligers deleted the ts-project-refs/index_pattern_management branch February 1, 2021 19:24

TinaHeiligers mentioned this pull request Feb 1, 2021

[7.x] Migrate indexPatternManagement to TS project ref (#89759) #89914

Merged

TinaHeiligers added a commit that referenced this pull request Feb 1, 2021

Migrate indexPatternManagement to TS project ref (#89759) (#89914)

04fcaba

peteharverson mentioned this pull request Feb 2, 2021

[ML] Transforms: Migrate plugin to TS project references #89271

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Migrate indexPatternManagement to TS project ref #89759

Migrate indexPatternManagement to TS project ref #89759

Uh oh!

TinaHeiligers commented Jan 29, 2021 •

edited

Loading

Uh oh!

elasticmachine commented Jan 29, 2021

Uh oh!

TinaHeiligers commented Jan 29, 2021

Uh oh!

kibanamachine commented Feb 1, 2021

Standard Out

Stack Trace

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Migrate indexPatternManagement to TS project ref #89759

Migrate indexPatternManagement to TS project ref #89759

Uh oh!

Conversation

TinaHeiligers commented Jan 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

elasticmachine commented Jan 29, 2021

Uh oh!

TinaHeiligers commented Jan 29, 2021

Uh oh!

kibanamachine commented Feb 1, 2021

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Metrics [docs]

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

TinaHeiligers commented Jan 29, 2021 •

edited

Loading