Merged
Conversation
Also update lodash imports and fix default exports
This is no longer needed with the Kibana syntax. Flash messages are set globally and only render when present.
In Kibana, we use the Eui components directly
It is used in security_logic
There is an error that recommends using AppMountParameters.onAppLeave instead, but it doesn't cover the case where a user navigates within the app. We'll revisit this problem later.
yakhinvadim
force-pushed
the
migrate-security-page
branch
from
37dc747 to
9881490
Compare
Also refactor PrivateSourcesTable to use static i18n strings.
Before we were using 'remote' and 'standard' as both enums and parts of copy, i.e. "Enable {sourceType} private sources".
But with i18n we can no longer do this. So I made a refactoring to separate these concerns. Now 'remote' and 'standard' are only used as enums. What i18n string to show is defined based on isRemote variable.
yakhinvadim
force-pushed
the
migrate-security-page
branch
from
9881490 to
4791093
Compare
Contributor
Author
|
I will update the PR with improved async tests after Jason's PR is merged. |
yakhinvadim
added
release_note:skip
scottybollinger
approved these changes
Jan 29, 2021
Contributor
scottybollinger
left a comment
scottybollinger
left a comment
There was a problem hiding this comment.
Couple of minor nits but looks great otherwise!
...ublic/applications/workplace_search/views/security/components/private_sources_table.test.tsx
Outdated
Show resolved
Hide resolved
...gins/enterprise_search/public/applications/workplace_search/views/security/security.test.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@scottybollinger Thanks for the review!
|
Contributor
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the Security tree from ent-search.
Public folder coverage:
Server folder coverage:
Checklist