[Security Solution] Narrow down indices to match case descriptions by angorayc · Pull Request #89592 · elastic/kibana

angorayc · 2021-01-28T16:53:15Z

Summary

This PR is to fix #87793

Before we put the defaultIndex of requests too broad, sometimes make the tests flaky.
Similar problem happens to other tests, so remove redundant index along here in this PR.

I also extend the timeout for each test to 10s to avoid returning partial data. For this users and uncommon_cases, I create two mock data which are smaller than the original ones they used. This should be able to reduce the query time.

elasticmachine · 2021-01-28T16:53:45Z

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

elasticmachine · 2021-01-28T16:53:45Z

Pinging @elastic/security-solution (Team: SecuritySolution)

kibanamachine · 2021-01-28T17:25:44Z

⏳ Build in-progress, with failures

continuous-integration/kibana-ci/pull-request
Commit: 57a28fa
This comment will update when the build is complete

Failed CI Steps

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

angorayc · 2021-01-29T08:48:17Z

@elasticmachine merge upstream

… into integration-defaultindex

…efaultindex

angorayc · 2021-02-08T16:17:46Z

@elasticmachine merge upstream

angorayc · 2021-02-08T19:37:45Z

@elasticmachine merge upstream

angorayc · 2021-02-09T12:45:36Z

@elasticmachine merge upstream

…efaultindex

angorayc · 2021-02-10T17:37:58Z

@elasticmachine merge upstream

michaelolo24 · 2021-02-10T19:52:07Z

+          defaultIndex: ['auditbeat-*'],
          docValueFields: [],
          inspect: false,
+          wait_for_completion_timeout: '10s',


Just curious how we settled on the 10s timeout?

Sometimes the request just takes longer than expected to return. I want to put the timeout long enough to wait until the result comes back so I am able to verify the result.

I checked the test here: https://github.com/elastic/kibana/blob/master/x-pack/test/api_integration/apis/search/search.ts#L18

They use a very long timeout to avoid returning just partial data, so I do the same here.

angorayc · 2021-02-14T07:26:43Z

@elasticmachine merge upstream

…efaultindex

… into integration-defaultindex

angorayc · 2021-02-22T13:59:32Z

@elasticmachine merge upstream

… into integration-defaultindex

XavierM

It seems that will do the work!!!

kibanamachine · 2021-02-22T20:50:07Z

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

💚 Build #108394 succeeded d729fc5
💚 Build #108352 succeeded 740a6d6
💚 Build #107704 succeeded fec1def
💚 Build #106445 succeeded d7bcd55
💚 Build #105695 succeeded 10200fc

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @angorayc

…lastic#89592) * update default index to match with description * narrow down indices to match case description * run specific tests * run only security solution's tests * debug users integration test * wait_for_completion_timeout * run only security_solution * add back integration tests * avoid multiple requests * uncomment tests * unskip tests * add smaller mock data for users and uncommon_processes * put test back Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/test/api_integration/apis/security_solution/users.ts

…ions (#89592) (#92284) * [Security Solution] Narrow down indices to match case descriptions (#89592) * update default index to match with description * narrow down indices to match case description * run specific tests * run only security solution's tests * debug users integration test * wait_for_completion_timeout * run only security_solution * add back integration tests * avoid multiple requests * uncomment tests * unskip tests * add smaller mock data for users and uncommon_processes * put test back Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/test/api_integration/apis/security_solution/users.ts * update mocked users data * update mocked index * update mocked index * update mocked index * update mock data

…ons (#89592) (#92283) * [Security Solution] Narrow down indices to match case descriptions (#89592) * update default index to match with description * narrow down indices to match case description * run specific tests * run only security solution's tests * debug users integration test * wait_for_completion_timeout * run only security_solution * add back integration tests * avoid multiple requests * uncomment tests * unskip tests * add smaller mock data for users and uncommon_processes * put test back Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/test/api_integration/apis/security_solution/users.ts * update mocked users data * update mocked index * update mocked index * update mocked index * update mock data * update mock data

angorayc added 2 commits January 28, 2021 20:26

update default index to match with description

544e442

narrow down indices to match case description

57a28fa

angorayc requested review from a team as code owners January 28, 2021 16:53

angorayc added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.11.1 labels Jan 28, 2021

angorayc added the release_note:skip Skip the PR/issue when compiling release notes label Jan 28, 2021

Merge branch 'master' into integration-defaultindex

4f9108d

angorayc self-assigned this Jan 29, 2021

angorayc added 3 commits January 29, 2021 23:31

run specific tests

b21ee5b

Merge branch 'integration-defaultindex' of github.com:angorayc/kibana…

fcfd7ee

… into integration-defaultindex

run only security solution's tests

c856aaf

angorayc closed this Feb 1, 2021

angorayc added 3 commits February 8, 2021 18:40

debug users integration test

78c2462

Merge branch 'master' of github.com:elastic/kibana into integration-d…

68153b8

…efaultindex

wait_for_completion_timeout

d2ee69f

angorayc reopened this Feb 8, 2021

run only security_solution

cf92515

Merge branch 'master' into integration-defaultindex

a67ce8c

Merge branch 'master' into integration-defaultindex

db7e1ad

kibanamachine and others added 2 commits February 9, 2021 07:45

Merge branch 'master' into integration-defaultindex

6363a40

Merge branch 'master' of github.com:elastic/kibana into integration-d…

8f70ea1

…efaultindex

Merge branch 'master' into integration-defaultindex

10200fc

michaelolo24 reviewed Feb 10, 2021

View reviewed changes

kibanamachine and others added 2 commits February 14, 2021 02:26

Merge branch 'master' into integration-defaultindex

d7bcd55

Merge branch 'master' of github.com:elastic/kibana into integration-d…

40940b2

…efaultindex

angorayc added v7.12.0 and removed v7.11.1 labels Feb 18, 2021

angorayc added 4 commits February 18, 2021 23:38

Merge branch 'integration-defaultindex' of github.com:angorayc/kibana…

fec1def

… into integration-defaultindex

uncomment tests

740a6d6

unskip tests

1dcb75a

add smaller mock data for users and uncommon_processes

f43c4f2

kibanamachine and others added 3 commits February 22, 2021 08:59

Merge branch 'master' into integration-defaultindex

d729fc5

put test back

e1ce1b1

Merge branch 'integration-defaultindex' of github.com:angorayc/kibana…

7d5f22a

… into integration-defaultindex

XavierM approved these changes Feb 22, 2021

View reviewed changes

angorayc merged commit 2df74a1 into elastic:master Feb 22, 2021

angorayc mentioned this pull request Feb 22, 2021

[7.x] [Security Solution] Narrow down indices to match case descriptions (#89592) #92283

Merged

This was referenced Feb 22, 2021

[7.12] [Security Solution] Narrow down indices to match case descriptions (#89592) #92284

Merged

[Security Solution] Remove unused mock data #92357

Merged

Conversation

angorayc commented Jan 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

elasticmachine commented Jan 28, 2021

Uh oh!

elasticmachine commented Jan 28, 2021

Uh oh!

kibanamachine commented Jan 28, 2021

⏳ Build in-progress, with failures

Failed CI Steps

Uh oh!

angorayc commented Jan 29, 2021

Uh oh!

angorayc commented Feb 8, 2021

Uh oh!

angorayc commented Feb 8, 2021

Uh oh!

angorayc commented Feb 9, 2021

Uh oh!

angorayc commented Feb 10, 2021

Uh oh!

michaelolo24 Feb 10, 2021

Choose a reason for hiding this comment

Uh oh!

angorayc Feb 14, 2021

Choose a reason for hiding this comment

Uh oh!

angorayc Feb 16, 2021

Choose a reason for hiding this comment

Uh oh!

angorayc commented Feb 14, 2021

Uh oh!

angorayc commented Feb 22, 2021

Uh oh!

XavierM left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Feb 22, 2021

💚 Build Succeeded

Metrics [docs]

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

angorayc commented Jan 28, 2021 •

edited

Loading