Skip to content

[7.x] Convert default_watch.json to a JS object in order to avoid TS complaints (#89488) #89515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2021
Merged

[7.x] Convert default_watch.json to a JS object in order to avoid TS complaints (#89488) #89515

merged 1 commit into from
Jan 28, 2021

Conversation

@cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Jan 28, 2021

Backports the following commits to 7.x:

@cjcenizal
Convert default_watch.json to a JS object in order to avoid TS compla…
28993f0 
…ints (elastic#89488)

* Remove unused defaultWatchJson static member from public JsonWatch model.
@cjcenizal cjcenizal added the backport This PR is a backport of another PR label Jan 28, 2021
@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 28, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
watcher 887.8KB 887.6KB -188.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cjcenizal cjcenizal merged commit 78d7dca into elastic:7.x Jan 28, 2021
@cjcenizal cjcenizal deleted the backport/7.x/pr-89488 branch January 28, 2021 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cjcenizal @kibanamachine