Skip to content

Conversation

@spalger
Copy link
Contributor

@spalger spalger commented Jan 27, 2021

Fixes #89373

When writing the final comment on PRs this change will ping the docs changes URL for the given PR, and if it responds with a 200 HTTP response include a link to that URL in the PR comment. If it responds with any other status the link will be dropped.

@spalger spalger added Team:Operations Kibana-Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v7.12.0 labels Jan 27, 2021
@spalger spalger force-pushed the implement/report-doc-changes-url-in-prs branch 3 times, most recently from e35d587 to 1b33207 Compare January 28, 2021 21:20
@spalger spalger force-pushed the implement/report-doc-changes-url-in-prs branch from a310cc1 to 1a5e1a5 Compare January 29, 2021 20:31
@spalger
Copy link
Contributor Author

spalger commented Jan 29, 2021

Example of a successful comment

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

...

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger marked this pull request as ready for review January 29, 2021 22:13
@spalger spalger requested a review from a team as a code owner January 29, 2021 22:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@spalger
Copy link
Contributor Author

spalger commented Jan 29, 2021

@elasticmachine merge upstream

@spalger spalger requested a review from brianseeders January 30, 2021 01:35
@spalger
Copy link
Contributor Author

spalger commented Feb 1, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit 3f96892 into elastic:master Feb 1, 2021
@spalger spalger deleted the implement/report-doc-changes-url-in-prs branch February 1, 2021 18:43
@spalger spalger added the v7.10.1 label Feb 1, 2021
spalger added a commit to spalger/kibana that referenced this pull request Feb 1, 2021
spalger added a commit to spalger/kibana that referenced this pull request Feb 1, 2021
spalger added a commit that referenced this pull request Feb 1, 2021
spalger added a commit that referenced this pull request Feb 1, 2021
…89908)

Co-authored-by: spalger <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: spalger <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
spalger added a commit that referenced this pull request Feb 1, 2021
…89907)

Co-authored-by: spalger <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: spalger <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.10.1 v7.11.0 v7.12.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add link to the docs ci build to the ci output

4 participants