Skip to content

Conversation

@cnasikas
Copy link
Member

@cnasikas cnasikas commented Jan 26, 2021

Summary

PR #84321 added the in-progress status. The UI in all cases page does not offer the ability to the user to change the status of the case to in-progress. This PR adds this functionality.

Status icon:

Open: folderOpen
In progress: folderExclamation
Closed: folderClosed

Screenshot 2021-02-15 at 6 21 30 PM

Screenshot 2021-02-15 at 6 21 20 PM

Screenshot 2021-02-15 at 6 21 11 PM

All cases: Status open

Screenshot 2021-02-15 at 6 20 52 PM

Screenshot 2021-02-15 at 6 20 44 PM

All cases: Status in progress

Screenshot 2021-02-15 at 6 20 30 PM

Screenshot 2021-02-15 at 6 20 15 PM

All cases: Status in closed

Screenshot 2021-02-15 at 6 20 03 PM

Screenshot 2021-02-15 at 6 19 53 PM

Demo

Add.in.progress.mp4

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cnasikas cnasikas added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Jan 26, 2021
@cnasikas cnasikas self-assigned this Jan 26, 2021
@cnasikas cnasikas force-pushed the all_cases_progress_action branch 2 times, most recently from c299ec2 to 9611eef Compare January 26, 2021 19:54
@cnasikas cnasikas force-pushed the all_cases_progress_action branch from 9611eef to 37f7565 Compare February 15, 2021 09:27
@cnasikas cnasikas marked this pull request as ready for review February 15, 2021 16:08
@cnasikas cnasikas requested a review from a team as a code owner February 15, 2021 16:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@cnasikas cnasikas requested a review from a team February 15, 2021 16:21
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please put into useCallback

Copy link
Member Author

@cnasikas cnasikas Feb 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get this error. I think is ok to leave it as it is as I have refactor to make it work.

React Hook "useCallback" is called in function "getBulkItems" that is neither a React function component nor a custom React Hook function. React component names must start with an uppercase letter.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please put into useCallback

Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need a few useCallbacks, other than that LGTM! Good job @cnasikas 🚀

@cnasikas
Copy link
Member Author

@elasticmachine merge upstream

@cnasikas cnasikas added v7.13.0 and removed v7.12.0 labels Feb 18, 2021
@cnasikas cnasikas force-pushed the all_cases_progress_action branch from c19f73b to 8258ce2 Compare February 18, 2021 09:52
@cnasikas cnasikas enabled auto-merge (squash) February 18, 2021 10:06
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 7.7MB 7.7MB +3.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 244.4KB 244.7KB +229.0B

History

  • 💚 Build #107274 succeeded c19f73bab65b450b76930ed968b1bf82140466f9
  • 💛 Build #106645 was flaky 25451be10016ff17acfa64ca1f82b5067db76acf
  • 💔 Build #106508 failed 37f75658b6175758cb8b58379e1b7213427bd17f
  • 💔 Build #101227 failed 9611eef40bdfeb3d597e1e3b543facc4fa42954d
  • 💔 Build #101208 failed 68cb029ee080845eb759ef45cfd0e0687f2593ea

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cnasikas added a commit that referenced this pull request Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.12.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants