Skip to content

Conversation

@estermv
Copy link
Contributor

@estermv estermv commented Jan 26, 2021

Summary

Fixes #89024.
As mentioned by @simianhacker comment this issue was caused by a change in the response for gauge type requests, so this PR:

  • Updates the type attribute from gauge to top_n in TSVB inventory models
  • Adds an integration test to check that there is more than one series returned for hostSystemOverview.

Checklist

Delete any items that are not applicable to this PR.

@estermv estermv added Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Jan 26, 2021
@estermv
Copy link
Contributor Author

estermv commented Jan 27, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@estermv estermv marked this pull request as ready for review January 27, 2021 15:24
@estermv estermv requested a review from a team as a code owner January 27, 2021 15:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

Copy link
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... Congrats on your first PR!

@estermv estermv merged commit 289ca57 into elastic:master Jan 27, 2021
estermv added a commit to estermv/kibana that referenced this pull request Jan 27, 2021
* change from type:gauge to type:top_n in inventory models

* Add test for hostSystemOverview metric

* fix lint errors

Co-authored-by: Kibana Machine <[email protected]>
estermv added a commit to estermv/kibana that referenced this pull request Jan 27, 2021
* change from type:gauge to type:top_n in inventory models

* Add test for hostSystemOverview metric

* fix lint errors

Co-authored-by: Kibana Machine <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 27, 2021
…ana into task-manager/shift-on-trend

* 'task-manager/shift-on-trend' of github.com:gmmorris/kibana: (74 commits)
  [Metrics UI] Fix Host Overview boxes in Host Detail page (elastic#89299)
  [Telemetry] Settings Collector: redact sensitive reported values (elastic#88675)
  [CI] Combines Jest test jobs (elastic#85850)
  [Upgrade Assistant] Migrate server to new es-js client (elastic#89207)
  Migrate maps_legacy, maps_oss, region_map, and tile_map plugions to TS projects (elastic#89351)
  [Vega Docs] Add experimental flag on the vega maps title (elastic#89402)
  Increase the time needed to locate the save viz toast (elastic#89301)
  [Enterprise Search] Add links to doc links service (elastic#89260)
  Fixed regex bug in Safari (elastic#89399)
  [Lens] Fix indexpattern checks for missing references (elastic#88840)
  [Lens] Clean up usage collector (elastic#89109)
  update apm index pattern (elastic#89395)
  [APM] Upgrade ES client (elastic#86594)
  Enable v2 so migrations, disable in FTR tests (elastic#89297)
  [Search Sessions] Make search session indicator UI opt-in, refactor per-app capabilities (elastic#88699)
  Cleanup OSS code from visualizations wizard (elastic#89092)
  [APM] Optimize API test order (elastic#88654)
  Rename conversion function, extract to module scope and add tests. (elastic#89018)
  [core.logging] Add ops logs to the KP logging system (elastic#88070)
  chore(NA): improve ts build refs performance on kbn bootstrap (elastic#89333)
  ...
estermv added a commit that referenced this pull request Jan 28, 2021
…9443)

* change from type:gauge to type:top_n in inventory models

* Add test for hostSystemOverview metric

* fix lint errors

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
estermv added a commit that referenced this pull request Jan 28, 2021
…9444)

* change from type:gauge to type:top_n in inventory models

* Add test for hostSystemOverview metric

* fix lint errors

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
@estermv estermv deleted the 89024-fix-host-overview-boxes branch January 29, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Metrics UI Metrics UI feature release_note:fix Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.11.0 v7.12.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Metrics UI] [Regression] Host Details page only shows CPU Usage box

4 participants