[App Search] Create engine view by byronhulcher · Pull Request #89156 · elastic/kibana

byronhulcher · 2021-01-25T15:09:22Z

Summary

This PR migrates the Create Engine view from ent-search, with improved test coverage and no custom STUI components.

Screenshots

Create Engine view: Empty state

Create Engine view: Supported languages

Create Engine view: Acceptable name

Create Engine view: Sanitized name

Create Engine view: Sanitized name with length of 0

Create Engine view: Duplicate engine name error state

Engine Overview view: Success message after engine creation

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

byronhulcher · 2021-01-27T18:29:39Z

Even though I'm setup inside our App router with an exact route I'm still seeing EngineRouter and the related EngineLogic being initialized.

easy solutions include "move Create Engine to a new path that won't conflict"

Hey @zumwalt what if this view lived under a path like http://localhost:5601/hxe/app/enterprise_search/app_search/create_engine instead of http://localhost:5601/hxe/app/enterprise_search/app_search/engines/new? Means I could skip investigating this for now

zumwalt · 2021-01-27T18:45:31Z

I'm fine with that if it unblocks you.

…ll firing??)

byronhulcher · 2021-01-30T01:51:57Z

.../enterprise_search/public/applications/app_search/components/create_engine/create_engine.tsx

  const { name, rawName, language } = useValues(CreateEngineLogic);
  const { setLanguage, setRawName, submitEngine } = useActions(CreateEngineLogic);

+  // TODO these need to come from AppLogic and/or the Enterprise Search server


If you're going commit by commit, I remove this in 04bdfbc#diff-529e95b2a96ac2a4737364f8304d2c07b6095cb2378c51fb63a329faf8d5b86aL46-L51

byronhulcher · 2021-01-30T01:52:33Z

x-pack/plugins/enterprise_search/public/applications/app_search/routes.ts


 export const ENGINES_PATH = '/engines';
-export const CREATE_ENGINES_PATH = `${ENGINES_PATH}/new`;
+export const CREATE_ENGINES_PATH = `/create_engine`;


@zumwalt is good with this change #89156 (comment)

byronhulcher · 2021-01-30T01:54:00Z

...e_search/public/applications/app_search/components/engine_overview/engine_overview_empty.tsx

I need this for displaying the setQueuedSuccessMessage from CreateEngineLogic.actions.onCreateEngineSuccess

byronhulcher · 2021-01-30T01:54:42Z

...search/public/applications/app_search/components/engine_overview/engine_overview_metrics.tsx

I don't need this here... but it seems silly not to include this the normal view if I'm including it in the empty state view

byronhulcher · 2021-01-30T01:55:48Z

...ugins/enterprise_search/public/applications/app_search/components/create_engine/constants.ts

Discussion to use a local constant for these values

byronhulcher · 2021-01-30T02:05:57Z

Opening a new PR with less messy history

kibanamachine · 2021-01-30T02:14:59Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 5f8beff
Pipeline Steps (look for red circles / failed steps)
Interpreting CI Failures

Failed CI Steps

Metrics [docs]

‼️ ERROR: metrics for 5f8beff were not reported

History

💔 Build #102415 failed a751e553995ce4ceffa3700b892f0701c064b58a
💔 Build #102409 failed d1d520efa01fad114e7fba2bcb95a99d82dcfb5b
💔 Build #101568 failed c7e98aaf5941fe65ad05c66b66a3395943ae914b
💔 Build #101515 failed 575e28ba7b2261740ad79e189ab52d19278ee603

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

byronhulcher force-pushed the create-engine-view branch 3 times, most recently from 86e1a2a to 63aec40 Compare January 27, 2021 15:38

elastic deleted a comment from kibanamachine Jan 27, 2021

byronhulcher force-pushed the create-engine-view branch from 44b4a90 to 8720f15 Compare January 27, 2021 16:57

This comment has been minimized.

Sign in to view

byronhulcher force-pushed the create-engine-view branch from aafc1f3 to c7e98aa Compare January 27, 2021 19:55

This comment has been minimized.

Sign in to view

byronhulcher added 14 commits January 29, 2021 20:48

New CreateEngine view component

1b3083d

Add CreateEngine to index router

9d92b03

Add Layout-level components for CreateEngine

cad6494

Static create engine view

4cc79b2

Add new POST route for engines API endpoint

3886740

Logic for Create Engine view WIP tests failing

7dae33b

Fix enterpriseSearchRequestHandler path

714fca7

Use setQueuedSuccessMessage after engine has been created

efc7de3

Use exact path for CREATE_ENGINES_PATH (but EngineRouter logic is sti…

49e7693

…ll firing??)

Add TODO note

6f7f512

Put CreateEngine inside the common App Search Layout

35b107f

Fix CreateEngineLogic jest tests

120c749

Move create engine view to /create_engine from /engines/new

be7a3df

Add Create an Engine button to Engines Overview

8737c69

byronhulcher force-pushed the create-engine-view branch from d1d520e to a751e55 Compare January 30, 2021 01:50

byronhulcher commented Jan 30, 2021

View reviewed changes

byronhulcher added 5 commits January 29, 2021 21:04

Missing FlashMessages on EngineOverview

3820860

Fix test for CreateEngine route

e9382fc

Fix strong'd text in santized name note

66dc0b6

Use local constant for Supported Languages

207f8b6

Disable submit button when name is empty

5f8beff

byronhulcher force-pushed the create-engine-view branch from a751e55 to 5f8beff Compare January 30, 2021 02:04

byronhulcher closed this Jan 30, 2021

byronhulcher mentioned this pull request Jan 30, 2021

[App Search] Migrate Create Engine view #89816

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[App Search] Create engine view#89156

[App Search] Create engine view#89156
byronhulcher wants to merge 19 commits intoelastic:masterfrom
byronhulcher:create-engine-view

byronhulcher commented Jan 25, 2021 •

edited

Loading

Uh oh!

This comment has been minimized.

byronhulcher commented Jan 27, 2021 •

edited

Loading

Uh oh!

zumwalt commented Jan 27, 2021

Uh oh!

This comment has been minimized.

byronhulcher Jan 30, 2021

Uh oh!

byronhulcher Jan 30, 2021

Uh oh!

byronhulcher Jan 30, 2021

Uh oh!

byronhulcher Jan 30, 2021

Uh oh!

byronhulcher Jan 30, 2021

Uh oh!

byronhulcher commented Jan 30, 2021

Uh oh!

kibanamachine commented Jan 30, 2021 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

byronhulcher commented Jan 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Screenshots

Create Engine view: Empty state

Create Engine view: Supported languages

Create Engine view: Acceptable name

Create Engine view: Sanitized name

Create Engine view: Sanitized name with length of 0

Create Engine view: Duplicate engine name error state

Engine Overview view: Success message after engine creation

Checklist

Uh oh!

This comment has been minimized.

byronhulcher commented Jan 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zumwalt commented Jan 27, 2021

Uh oh!

This comment has been minimized.

byronhulcher Jan 30, 2021

Choose a reason for hiding this comment

Uh oh!

byronhulcher Jan 30, 2021

Choose a reason for hiding this comment

Uh oh!

byronhulcher Jan 30, 2021

Choose a reason for hiding this comment

Uh oh!

byronhulcher Jan 30, 2021

Choose a reason for hiding this comment

Uh oh!

byronhulcher Jan 30, 2021

Choose a reason for hiding this comment

Uh oh!

byronhulcher commented Jan 30, 2021

Uh oh!

kibanamachine commented Jan 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

Metrics [docs]

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

byronhulcher commented Jan 25, 2021 •

edited

Loading

byronhulcher commented Jan 27, 2021 •

edited

Loading

kibanamachine commented Jan 30, 2021 •

edited

Loading