Skip to content

[APM] Break down error table api removing the sparklines #89138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Feb 19, 2021
Merged

[APM] Break down error table api removing the sparklines #89138

merged 22 commits into from
Feb 19, 2021

Conversation

@cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Jan 25, 2021 •
edited
Loading

closes #89098

/api/apm/services/opbeans-java/error_groups:

{
   "total_error_groups":1,
   "is_aggregation_accurate":true,
   "error_groups":[
      {
         "group_id":"25fae1b27007f121924df65fcee1b115",
         "name":"Connection reset by peer",
         "last_seen":1611583752233,
         "occurrences":{
            "value":5
         }
      }
   ]
}

/api/apm/services/opbeans-java/error_groups/metrics:

{
   "25fae1b27007f121924df65fcee1b115":{
      "timeseries":[
         {
            "x":1611582060000,
            "y":0
         },
        ...
      ]
   }
}

Screenshot 2021-01-25 at 15 13 47

Screenshot 2021-01-25 at 15 13 53

@cauemarcondes cauemarcondes marked this pull request as ready for review January 25, 2021 14:59
@cauemarcondes cauemarcondes requested a review from a team as a code owner January 25, 2021 14:59
@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Feb 1, 2021
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 1, 2021

Pinging @elastic/apm-ui (Team:apm)

@spalger
Copy link
Contributor

spalger commented Feb 3, 2021

jenkins test this

@cauemarcondes
Copy link
Contributor Author

cauemarcondes commented Feb 8, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 8, 2021

expected head sha didn’t match current head ref.

@dgieselaar
Copy link
Member

dgieselaar commented Feb 13, 2021

@elasticmachine merge upstream

@cauemarcondes cauemarcondes mentioned this pull request Feb 15, 2021
Merged
sorenlouv
sorenlouv reviewed Feb 18, 2021
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. @dgieselaar?

dgieselaar
dgieselaar reviewed Feb 19, 2021
View reviewed changes
dgieselaar
dgieselaar reviewed Feb 19, 2021
View reviewed changes
Copy link
Member

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's not a lot left but I think that we should add some more API tests. The tests that we had previously are more complete. Thanks for persevering Cauê!

dgieselaar
dgieselaar approved these changes Feb 19, 2021
View reviewed changes
Copy link
Member

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 19, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1735 1736 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.2MB 5.2MB +1018.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit 405255c into elastic:master Feb 19, 2021
@cauemarcondes cauemarcondes deleted the apm-error-table-api branch February 19, 2021 17:55
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Feb 19, 2021
@cauemarcondes @kibanamachine @dgieselaar
[APM] Break down error table api removing the sparklines (elastic#89138)
94a29bf 
* breaking error table api

* shows loading state while fetching metrics

* adding api tests

* removing pagination from server

* adding API test

* refactoring

* fixing license

* renaming apis

* fixing some stuff

* addressing PR comments

* adding request id

* addressing PR comments

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Dario Gieselaar <[email protected]>
@cauemarcondes cauemarcondes mentioned this pull request Feb 19, 2021
Merged
cauemarcondes added a commit that referenced this pull request Feb 19, 2021
@cauemarcondes @kibanamachine @dgieselaar
[APM] Break down error table api removing the sparklines (#89138) (#9…
980f050 
…2059)

* breaking error table api

* shows loading state while fetching metrics

* adding api tests

* removing pagination from server

* adding API test

* refactoring

* fixing license

* renaming apis

* fixing some stuff

* addressing PR comments

* adding request id

* addressing PR comments

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Dario Gieselaar <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Dario Gieselaar <[email protected]>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 22, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ilm/update-co…
b4d6ef5 
…ndition-for-hiding-recommded-allocation

* 'master' of github.com:elastic/kibana: (117 commits)
  [coverage] ingest data in parallel (elastic#92074)
  [Lens] Drag and drop performance improvements (elastic#91641)
  A few more environment uiFilters fixes (elastic#92044)
  Enabling Uptime and Dashboard a11y test (elastic#91017)
  [Security Solution][Detections] Adds more granular validation for nested fields (elastic#92041)
  [Security Solution] [Detections] add overflow-wrap for description (elastic#91945)
  [Security Solution] [Detections] do not truncate filename in value list table in modal (elastic#91952)
  Skip flaky apm test elastic#91673 (elastic#92065)
  [docker] Default server.name to hostname (elastic#90799)
  Use documentation link service for snapshot restore (elastic#91596)
  [Security Solution] Clearing up all jest errors and warnings (elastic#91740)
  Add `@kbn/analytics` to UI Shared Deps (elastic#91810)
  [7.12][Telemetry] Add missing fields for security telemetry (elastic#91920)
  [Security Solution] Adds cypress-pipe (elastic#91550)
  [ML] Fix event rate chart annotation position (elastic#91899)
  [APM] Break down error table api removing the sparklines (elastic#89138)
  docs: update dependencies table bug (elastic#91964)
  [Time to Visualize] Stay in Edit Mode After Dashboard Quicksave (elastic#91729)
  Unskip Search Sessions Management UI test (elastic#90110)
  [Fleet] Handle long text in agent details page (elastic#91776)
  ...

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/edit_policy.helpers.tsx
#	x-pack/plugins/index_lifecycle_management/__jest__/components/edit_policy.test.tsx
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 22, 2021
@gmmorris
Merge branch 'task-manager/docs-monitoring' of github.com:gmmorris/ki…
f3d2e70 
…bana into task-manager/docs-monitoring

* 'task-manager/docs-monitoring' of github.com:gmmorris/kibana: (29 commits)
  Update docs/developer/plugin-list.asciidoc
  Update docs/api/task-manager/health.asciidoc
  Update docs/api/task-manager/health.asciidoc
  [Lens] Load indexpatterns list from indexPattern Service (elastic#91984)
  [coverage] ingest data in parallel (elastic#92074)
  [Lens] Drag and drop performance improvements (elastic#91641)
  A few more environment uiFilters fixes (elastic#92044)
  Enabling Uptime and Dashboard a11y test (elastic#91017)
  [Security Solution][Detections] Adds more granular validation for nested fields (elastic#92041)
  [Security Solution] [Detections] add overflow-wrap for description (elastic#91945)
  [Security Solution] [Detections] do not truncate filename in value list table in modal (elastic#91952)
  Skip flaky apm test elastic#91673 (elastic#92065)
  [docker] Default server.name to hostname (elastic#90799)
  Use documentation link service for snapshot restore (elastic#91596)
  [Security Solution] Clearing up all jest errors and warnings (elastic#91740)
  Add `@kbn/analytics` to UI Shared Deps (elastic#91810)
  [7.12][Telemetry] Add missing fields for security telemetry (elastic#91920)
  [Security Solution] Adds cypress-pipe (elastic#91550)
  [ML] Fix event rate chart annotation position (elastic#91899)
  [APM] Break down error table api removing the sparklines (elastic#89138)
  ...
@cauemarcondes cauemarcondes mentioned this pull request Apr 21, 2021
Closed
@ogupte ogupte self-assigned this May 10, 2021
@ogupte ogupte added the apm:test-plan-done Pull request that was successfully tested during the test plan label May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgieselaar dgieselaar dgieselaar approved these changes

@sorenlouv sorenlouv Awaiting requested review from sorenlouv

Assignees

@ogupte ogupte

Labels

apm:comparison apm:test-plan-7.13.0 apm:test-plan-done Pull request that was successfully tested during the test plan release_note:enhancement Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.13.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[APM] Break down error table api removing the sparklines

7 participants

@cauemarcondes @elasticmachine @spalger @kibanamachine @dgieselaar @sorenlouv @ogupte