Skip to content

Improve documentation for index pattern custom label #89137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 26, 2021
Merged

Improve documentation for index pattern custom label #89137

merged 4 commits into from
Jan 26, 2021

Conversation

@kertal
Copy link
Member

@kertal kertal commented Jan 25, 2021 •
edited
Loading

Summary

Improve custom label documentation, follow up of #70039

Checklist

Delete any items that are not applicable to this PR.

  • Documentation was added for features that require explanation or tutorials

@kertal kertal added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// Feature:Data Views Data Views code and UI - index patterns before 8.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v7.12.0 documentation labels Jan 25, 2021
@kertal kertal requested a review from gchaps January 25, 2021 13:49
@kertal kertal self-assigned this Jan 25, 2021
kertal
kertal commented Jan 25, 2021
View reviewed changes
Copy link
Member Author

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gchaps it's fine to use retina resolution screens, right?

gchaps
gchaps reviewed Jan 25, 2021
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you reduce the size of the image? It is a rather large in comparison to the surrounding text.

@kertal kertal requested a review from gchaps January 25, 2021 18:43
gchaps
gchaps approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kertal kertal marked this pull request as ready for review January 26, 2021 04:53
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 26, 2021

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal kertal merged commit f5e8691 into master Jan 26, 2021
kertal added a commit to kertal/kibana that referenced this pull request Jan 26, 2021
@kertal @gchaps
Improve documentation for index pattern custom label (elastic#89137)
f048e93 
Co-authored-by: gchaps <[email protected]>
This was referenced Jan 26, 2021
Merged
Merged
kertal added a commit to kertal/kibana that referenced this pull request Jan 26, 2021
@kertal @gchaps
Improve documentation for index pattern custom label (elastic#89137)
a9907ce 
Co-authored-by: gchaps <[email protected]>
kertal added a commit that referenced this pull request Jan 26, 2021
@kertal @gchaps
Improve documentation for index pattern custom label (#89137) (#89262)
87aca3a 
Co-authored-by: gchaps <[email protected]>
kertal added a commit that referenced this pull request Jan 26, 2021
@kertal @gchaps
Improve documentation for index pattern custom label (#89137) (#89261)
920802f 
Co-authored-by: gchaps <[email protected]>
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 26, 2021

Pinging @elastic/kibana-docs (Team:Docs)

@kertal kertal deleted the kertal-pr-2021-01-25-custom-label-doc branch April 21, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gchaps gchaps gchaps approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kertal kertal

Labels

Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes Team:Docs Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.11.0 v7.12.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kertal @elasticmachine @gchaps