[Security Solution] Cypress reorganization#88687
Merged
MadameSheema merged 10 commits intoelastic:masterfrom Jan 20, 2021
Merged
[Security Solution] Cypress reorganization#88687MadameSheema merged 10 commits intoelastic:masterfrom
MadameSheema merged 10 commits intoelastic:masterfrom
Conversation
FrankHassanabad
approved these changes
Jan 19, 2021
Contributor
FrankHassanabad
left a comment
There was a problem hiding this comment.
LGTM, thanks for the re-organization for code growth. Looks great.
angorayc
approved these changes
Jan 20, 2021
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💛 Build succeeded, but was flaky
Test FailuresChrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/connectors·ts.Actions and Triggers app Connectors should test a connector and display a successful resultStandard OutStack TraceMetrics [docs]
History
To update your PR or re-run it, just comment with: |
MadameSheema
added a commit
to MadameSheema/kibana
that referenced
this pull request
Jan 20, 2021
* moves tests to different folders * cases test files renaming * renames detection alerts test files * renames detection rules test files * renames exceptions test files * splits inspect test files * renames timeline templates file tests * renames timelines file tests * renames url file tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Member
|
@MadameSheema Looks like we might have a typo on one file name:
want me to fix? |
Contributor
Author
|
Good cath @pzl! Sure, lots of thanks for your help ❤️ |
MadameSheema
added a commit
that referenced
this pull request
Jan 20, 2021
* moves tests to different folders * cases test files renaming * renames detection alerts test files * renames detection rules test files * renames exceptions test files * splits inspect test files * renames timeline templates file tests * renames timelines file tests * renames url file tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As the number of cypress spec files has increased a lot, in this PR we are organising the spec files in different folders.