Remove src/plugins/visualizations -> src/plugins/visualize cyclic dependencies #87797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
alexwizp
force-pushed
the
86758-4
branch
2 times, most recently
from
a14aee8 to
cd92598
Compare
alexwizp
added
v7.12.0
v8.0.0
Team:Visualizations
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
mistic
approved these changes
Jan 11, 2021
Member
mistic
left a comment
mistic
left a comment
There was a problem hiding this comment.
Code under Operations team code owners LGTM
stratoula
approved these changes
Jan 12, 2021
Contributor
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
LGTM, since we would like to merge these two plugins in the future it makes sense to move these types to visualizations plugin. I tested it locally and works fine
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Jan 12, 2021
…endencies (elastic#87797) * Remove src/plugins/visualizations -> src/plugins/visualize cyclic dependencies Part of elastic#84750 * fix types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #84750
Summary
Removes circular dependencies between
src/plugins/visualizationsandsrc/plugins/visualizeplugins.The dependencies that were removed based on the
node scripts/find_plugins_with_circular_deps --debugscript.What was changed in that PR:
EditorRenderProps,IEditorController,VisEditorConstructortypes were moved fromvisualizetovisualizationsplugin.