chore(NA): move maps plugin test fixtures out of __tests__ folder #87764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistic
added
chore
Team:Operations
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
mistic
requested review from
thomasneirynck
and removed request for
thomasneirynck
tylersmalley
approved these changes
Jan 8, 2021
thomasneirynck
approved these changes
Jan 11, 2021
Contributor
thomasneirynck
left a comment
thomasneirynck
left a comment
There was a problem hiding this comment.
code review, thanks you @mistic
Member
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Jan 11, 2021
…astic#87764) * chore(NA): move maps plugin test fixtures out of __tests__ folder * chore(NA): last missing __tests__ folders renamed Co-authored-by: Kibana Machine <[email protected]>
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Jan 11, 2021
…astic#87764) * chore(NA): move maps plugin test fixtures out of __tests__ folder * chore(NA): last missing __tests__ folders renamed Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # x-pack/plugins/maps/server/mvt/__fixtures__/pbf/0_0_0_docs.pbf # x-pack/plugins/maps/server/mvt/__fixtures__/pbf/0_0_0_grid_asgrid.pbf # x-pack/plugins/maps/server/mvt/__fixtures__/pbf/0_0_0_grid_aspoint.pbf
Member
Author
|
7.x/7.12: 965d775 |
mistic
added a commit
that referenced
this pull request
Jan 12, 2021
…7764) (#87875) * chore(NA): move maps plugin test fixtures out of __tests__ folder * chore(NA): last missing __tests__ folders renamed Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
mistic
added a commit
that referenced
this pull request
Jan 12, 2021
…der (#87764) (#87880) * chore(NA): move maps plugin test fixtures out of __tests__ folder (#87764) * chore(NA): move maps plugin test fixtures out of __tests__ folder * chore(NA): last missing __tests__ folders renamed Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # x-pack/plugins/maps/server/mvt/__fixtures__/pbf/0_0_0_docs.pbf # x-pack/plugins/maps/server/mvt/__fixtures__/pbf/0_0_0_grid_asgrid.pbf # x-pack/plugins/maps/server/mvt/__fixtures__/pbf/0_0_0_grid_aspoint.pbf * test(NA): fix failing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It moves the second item of #85513 forward as it moves maps tests out of tests folder into our common setup for tests run with jest.