Conversation
--------- **Commit 1:** UI Settings disabled when plugins.initialize is false * Original sha: c6f90e2 * Authored by = <brandon.kobel@elastic.co> on 2016-10-19T20:47:05Z **Commit 2:** Moving where we're disabling the ui settings * Original sha: e66c7e7 * Authored by = <brandon.kobel@elastic.co> on 2016-10-19T21:22:52Z **Commit 3:** [server/uiSettings] add enabled config in response to matt's comment that relying on `plugins.initialize` is kinda dirty (with which we all agree) we're adding an undocumented config value that the dev cli can use to put prevent the optimizr server from logging meaningless warnings * Original sha: 40ffd12 * Authored by spalger <email@spalger.com> on 2016-10-19T23:24:55Z **Commit 4:** [server/uiSettings] react to missing elasticsearch plugin * Original sha: 7feacf6 * Authored by spalger <email@spalger.com> on 2016-10-19T23:26:44Z **Commit 5:** [server/uiSettings] fix da tests * Original sha: c2d7d01 * Authored by spalger <email@spalger.com> on 2016-10-19T23:36:11Z **Commit 6:** [server/uiSettings] document enabled config * Original sha: f9bd154 * Authored by Spencer <spalger@users.noreply.github.com> on 2016-10-19T23:52:28Z * Committed by GitHub <noreply@github.com> on 2016-10-19T23:52:28Z
spalger
changed the title
(cherry picked from commit 6865281)
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
[backport] PR elastic#8764 to 5.x - UI Settings should be disabled when elasticsearch is not available Former-commit-id: 07b6453
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport PR #8764
Commit 1:
UI Settings disabled when plugins.initialize is false
Commit 2:
Moving where we're disabling the ui settings
Commit 3:
[server/uiSettings] add enabled config
in response to matt's comment that relying on
plugins.initializeis kinda dirty (with which we all agree) we're adding an undocumented config value that the dev cli can use to put prevent the optimizr server from logging meaningless warningsCommit 4:
[server/uiSettings] react to missing elasticsearch plugin
Commit 5:
[server/uiSettings] fix da tests
Commit 6:
[server/uiSettings] document enabled config