Improve breaking changes documentation#8753
Merged
Bargs merged 2 commits intoelastic:5.xfrom Oct 21, 2016
Merged
Conversation
Contributor
|
lgtm thx! |
Contributor
|
@Bargs this is great, but can you add the core of this change to master and 5.x as well? The 5.x branch should be the same as this, since users going from 4.x to 5.x are going to have to deal with the same breaking changes from 5.0. Master can be set up for 6.0 and empty for the time being. |
Contributor
Author
|
@epixa ah good point, I should have issued this against 5.x. The base branch is now updated. I was going to do 6.0 once the format was reviewed and approved in 5.x |
Contributor
|
Awesome. LGTM then, so go nuts. I'll be doing heavy doc work tomorrow and Monday, so let's get the BC docs changes in. |
elastic-jasper
added a commit
that referenced
this pull request
Oct 21, 2016
--------- **Commit 1:** Align better with ES doc structure * Original sha: 48c3da7 * Authored by Matthew Bargar <mbargar@gmail.com> on 2016-10-18T22:22:53Z **Commit 2:** Improve formatting and details of breaking changes docs * Original sha: 4a59a7c * Authored by Matthew Bargar <mbargar@gmail.com> on 2016-10-19T16:55:06Z
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Improve breaking changes documentation Former-commit-id: ac2b127
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added details for each change and changed the organization a bit to better align with the structure of the ES breaking change docs.
Fixes #8703