[Enterprise Search] Kea mount test helper#87247
Merged
cee-chen merged 3 commits intoelastic:masterfrom Jan 6, 2021
Merged
Conversation
17 tasks
Contributor
Author
|
@scottybollinger FYI - you may find this helper useful in your Workplace Search logic tests as well. You can use it in logic file tests to pass default values without having to manually set them. It also handles |
scottybollinger
approved these changes
Jan 4, 2021
Contributor
scottybollinger
left a comment
There was a problem hiding this comment.
This is awesome! Can't wait to use it. Thanks Constance!
cee-chen
commented
Jan 4, 2021
Comment on lines
105
to
106
Contributor
Author
There was a problem hiding this comment.
Example path:
['enterprise_search', 'app_search', 'engine_overview_logic']
Example defaults:
{
defaults: {
enterprise_search: {
app_search: {
engine_overview_logic: {
...values
}
}
}
}
}
I've never actually seen/used .reduceRight before this but was super surprised at how easy it was to find a one-liner that did exactly what we wanted 🤯
eb322d9 to
4c57493
Compare
Contributor
💚 Build SucceededMetrics [docs]Distributable file count
History
To update your PR or re-run it, just comment with: |
JasonStoltz
approved these changes
Jan 6, 2021
Member
JasonStoltz
left a comment
There was a problem hiding this comment.
Thanks for doing this Constance!
cee-chen
pushed a commit
that referenced
this pull request
Jan 6, 2021
* Add Kea logic mount helper * Update existing mount() helpers to use new DRY helper * Add additional unmount helper + example test update Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After discussing this in a previous PR (#86822 (review)), I went ahead and created a test helper that DRY's out our repeated
mounthelpers across several tests. Super huge thanks to Jason for giving an example API!Usage:
Checklist