[dev/cli] stop trimming log lines from the server #87199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
dgieselaar
approved these changes
Jan 4, 2021
Member
dgieselaar
left a comment
dgieselaar
left a comment
There was a problem hiding this comment.
Works like a charm! Thanks Spencer.
Contributor
💚 Build SucceededMetrics [docs]Distributable file count
History
To update your PR or re-run it, just comment with: |
jbudz
approved these changes
Jan 4, 2021
This was referenced Jan 4, 2021
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Jan 4, 2021
Co-authored-by: spalger <[email protected]>
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Jan 4, 2021
Co-authored-by: spalger <[email protected]>
spalger
added a commit
that referenced
this pull request
Jan 4, 2021
) Co-authored-by: spalger <[email protected]> Co-authored-by: spalger <[email protected]>
spalger
added a commit
that referenced
this pull request
Jan 4, 2021
…7230) Co-authored-by: spalger <[email protected]> Co-authored-by: spalger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dgieselaar noticed that with #84726 I accidentally started trimming the log lines that come from the server, causing indentation of multi-line messages to be removed. This updates the
Log#write()interface used in the dev cli to pass all arguments directly toconsole.log(), rather than treating the first argument as a label like we do in other methods. This interface is destined to be removed but I'm just not quite ready to do that yet.