Skip to content

Conversation

@dhurley14
Copy link
Contributor

@dhurley14 dhurley14 commented Dec 23, 2020

Summary

Ref: #86874

replaces should with a single lower bounded and upper bounded date range filter.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@dhurley14 dhurley14 self-assigned this Dec 23, 2020
@dhurley14 dhurley14 force-pushed the replace-should-date branch from b70b098 to 477682b Compare January 5, 2021 22:50
@dhurley14 dhurley14 force-pushed the replace-should-date branch from 93fa98a to e015a07 Compare January 5, 2021 23:16
@dhurley14 dhurley14 marked this pull request as ready for review January 5, 2021 23:32
@dhurley14 dhurley14 requested review from a team as code owners January 5, 2021 23:32
@dhurley14 dhurley14 added release_note:fix review Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detections and Resp Security Detection Response Team v7.11.0 v7.12.0 v8.0.0 labels Jan 5, 2021
@spong
Copy link
Member

spong commented Jan 6, 2021

@elasticmachine merge upstream

Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once green -- thanks @dhurley14! 🙂

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spong spong merged commit b4bbd93 into elastic:master Jan 6, 2021
spong pushed a commit to spong/kibana that referenced this pull request Jan 6, 2021
…e date range filter (elastic#86921)

## Summary

Ref: elastic#86874



replaces `should` with a single lower bounded and upper bounded date range filter.

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
spong pushed a commit to spong/kibana that referenced this pull request Jan 6, 2021
…e date range filter (elastic#86921)

## Summary

Ref: elastic#86874



replaces `should` with a single lower bounded and upper bounded date range filter.

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
peluja1012 pushed a commit that referenced this pull request Jan 6, 2021
…e date range filter (#86921) (#87428)

## Summary

Ref: #86874



replaces `should` with a single lower bounded and upper bounded date range filter.

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

Co-authored-by: Devin W. Hurley <[email protected]>
peluja1012 pushed a commit that referenced this pull request Jan 6, 2021
…e date range filter (#86921) (#87429)

## Summary

Ref: #86874



replaces `should` with a single lower bounded and upper bounded date range filter.

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

Co-authored-by: Devin W. Hurley <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:fix review Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.11.0 v7.12.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Security Solution] Improve time filter efficiency for Detection Rules

3 participants