[backport] PR #8642 to 5.x - Scripted fields must reference values via params when filtering#8675
Merged
stacey-gammon merged 1 commit into5.xfrom Oct 13, 2016
Merged
Conversation
--------- **Commit 1:** Fix our request to ES for filtering on scripted fields Need to use params.value instead of value. Fixes #8404 Add params prefix in another spot for painless scripted fields Fix date histogram with scripted fields Remove format: epoch_millis so the script compiles. I am not 100% confident of the side affect from this (it’s used for non-scripted fields, but I’m not sure where I would put it for scripted fields, or if it’s needed). At any rate, it appears that formatting settings for scripted fields is still being honored, even after removing it from params. * Original sha: 7cdb74d * Authored by Stacey Gammon <gammon@elastic.co> on 2016-10-12T14:54:23Z
epixa
changed the title
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
[backport] PR elastic#8642 to 5.x Former-commit-id: e080b85
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport PR #8642
Commit 1:
Fix our request to ES for filtering on scripted fields
Need to use params.value instead of value.
Fixes #8404
Add params prefix in another spot for painless scripted fields
Fix date histogram with scripted fields
Remove format: epoch_millis so the script compiles. I am not 100%
confident of the side affect from this (it’s used for non-scripted
fields, but I’m not sure where I would put it for scripted fields, or
if it’s needed). At any rate, it appears that formatting settings for
scripted fields is still being honored, even after removing it from
params.