[App Search] Sample Engines should have access to the Crawler #86502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- primarily a UI thing - ideally we always want to show 4 buttons
cee-chen
added
Feature:Plugins
release_note:skip
Contributor
Author
|
FYI on this @byronhulcher - Casey said we didn't have to change this in the standalone UI and this can be a Kibana-only change, but something to keep in mind when Crawler gets ported over to Kibana |
cee-chen
commented
Dec 18, 2020
| const { | ||
| myRole: { canViewEngineCrawler }, | ||
| } = useValues(AppLogic); | ||
| const showCrawlerLink = canViewEngineCrawler && !isSampleEngine; |
Contributor
Author
There was a problem hiding this comment.
I also just confirmed in the Crawler channel w/ Rich that there's no realistic scenario where a user would have access to document creation (upload/pasting JSON) and not have access to the Crawler, so I think this access check is also safe to remove
cee-chen
changed the title
JasonStoltz
approved these changes
Dec 18, 2020
JasonStoltz
approved these changes
Dec 18, 2020
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
To update your PR or re-run it, just comment with: |
cee-chen
pushed a commit
that referenced
this pull request
Dec 18, 2020
#86539) * Remove logic preventing Crawler from being used on sample engines * Remove check around crawler button in DocumentCreationButtons - primarily a UI thing - ideally we always want to show 4 buttons
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Dec 21, 2020
* master: (48 commits) Fix request with disabled aggregation (elastic#85696) [Security Solution][Detections][Threshold Rules] Threshold Rule Bug Fixes (elastic#84918) Removed a possibility to define two different names for Alert types on API and UI level. (elastic#86236) Bump Node.js from version 14.15.2 to 14.15.3 (elastic#86593) [index patterns] Fleep app - Keep saved object field list until field caps provides fields (elastic#85370) [Security Solutions] fix timeline tabs + layout (elastic#86581) Upgrade to hapi version 20 (elastic#85406) App Services: Remove remaining uiActions, expressions, data, embeddable circular dependencies. (elastic#82791) Rename chartLibrary setting to legacyChartsLibrary (elastic#86529) [CI] TeamCity updates (elastic#85843) [Maps] Use Json for mvt-tests (elastic#86492) [Rollup Jobs] Added autofocus to cron editor (elastic#86324) [Monitoring][Alerting] CCR read exceptions alert (elastic#85908) [CI] Bump memory for main CI workers (elastic#86541) Explicitly set Elasticsearch heap size during CI and local development (elastic#86513) [App Search] Updates to results on the documents view (elastic#86181) [Discover] Change default sort handling (elastic#85561) [App Search] Convert DocumentCreationModal to DocumentCreationFlyout (elastic#86508) [App Search] Sample Engines should have access to the Crawler (elastic#86502) Fixed duplication of create new modal (elastic#86489) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I was going over the new DocumentCreation modal with @zumwalt the other day, and he confirmed that if sample engines can index new documents, there's no reason why they shouldn't have access to the Crawler. I've removed checks around
isSampleEnginefor crawler links, and the DocumentCreationButtons should now always show 4 buttons.QA
Checklist