Console now autocompletes indexes#8557
Merged
kobelb merged 1 commit intoelastic:masterfrom Oct 12, 2016
Merged
Conversation
epixa
changed the title
Contributor
|
LGTM |
lukasolson
approved these changes
Oct 10, 2016
elastic-jasper
added a commit
that referenced
this pull request
Oct 12, 2016
--------- **Commit 1:** Resolving bug with console not autocompleting indexes * Original sha: 0ae3779 * Authored by = <brandon.kobel@elastic.co> on 2016-10-05T15:07:43Z
Contributor
Author
|
@epixa based on our conversations regarding adopting ES's policy of what gets into a patch version, is this something that you think should be merged into 5.0.0? Still trying to calibrate my definition of 'critical'. |
Contributor
|
@kobelb Nope |
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
[backport] PR elastic#8557 to 5.x Former-commit-id: b74c43a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8531
The
mappings.retrieveAutocompleteInfoFromServerfunction used to be called when the 'es' module called all callbacks registered viaaddServerChangeListener. This was removed by fee819d so I'm instead calling this method in theapp.initfunction.There might be a more appropriate place to put this call.