Reduce memory leaks in visualization tests#8537
Merged
stacey-gammon merged 1 commit intoelastic:masterfrom Oct 5, 2016
Merged
Conversation
These are the biggest offenders of dom node leaks during the browser tests runs (there are more - specifically with leakage of $rootScope.$new not being subsequently destroyed, but that takes up significantly less memory). This fix lets me run browser tests with consistent results.
Author
|
jenkins test this |
Contributor
|
I ran the test suite a few times on Chrome/FF on Ubuntu 16. It always complete reliably, without time-out errors. LGTM |
Member
|
LGTM |
elastic-jasper
added a commit
that referenced
this pull request
Oct 5, 2016
--------- **Commit 1:** Reduce memory leaks in visualization tests These are the biggest offenders of dom node leaks during the browser tests runs (there are more - specifically with leakage of $rootScope.$new not being subsequently destroyed, but that takes up significantly less memory). This fix lets me run browser tests with consistent results. * Original sha: 5affa99 * Authored by Stacey Gammon <gammon@elastic.co> on 2016-10-04T18:33:42Z
elastic-jasper
added a commit
that referenced
this pull request
Oct 5, 2016
--------- **Commit 1:** Reduce memory leaks in visualization tests These are the biggest offenders of dom node leaks during the browser tests runs (there are more - specifically with leakage of $rootScope.$new not being subsequently destroyed, but that takes up significantly less memory). This fix lets me run browser tests with consistent results. * Original sha: 5affa99 * Authored by Stacey Gammon <gammon@elastic.co> on 2016-10-04T18:33:42Z
elastic-jasper
added a commit
that referenced
this pull request
Oct 5, 2016
--------- **Commit 1:** Reduce memory leaks in visualization tests These are the biggest offenders of dom node leaks during the browser tests runs (there are more - specifically with leakage of $rootScope.$new not being subsequently destroyed, but that takes up significantly less memory). This fix lets me run browser tests with consistent results. * Original sha: 5affa99 * Authored by Stacey Gammon <gammon@elastic.co> on 2016-10-04T18:33:42Z
stacey-gammon
pushed a commit
that referenced
this pull request
Oct 5, 2016
[backport] PR #8537 to 4.6 - Reduce memory leaks in visualization tests
stacey-gammon
pushed a commit
that referenced
this pull request
Oct 5, 2016
[backport] PR #8537 to 5.0 - Reduce memory leaks in visualization tests
stacey-gammon
pushed a commit
that referenced
this pull request
Oct 5, 2016
[backport] PR #8537 to 5.x - Reduce memory leaks in visualization tests
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
--------- **Commit 1:** Reduce memory leaks in visualization tests These are the biggest offenders of dom node leaks during the browser tests runs (there are more - specifically with leakage of $rootScope.$new not being subsequently destroyed, but that takes up significantly less memory). This fix lets me run browser tests with consistent results. * Original sha: 58376c9dfac156b376ff8cdb098bc04a59338ed8 [formerly 5affa99] * Authored by Stacey Gammon <gammon@elastic.co> on 2016-10-04T18:33:42Z Former-commit-id: d5e8023
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
[backport] PR elastic#8537 to 5.x - Reduce memory leaks in visualization tests Former-commit-id: f42a5f3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the biggest offenders of dom node leaks during the browser
tests runs (there are more - specifically with leakage of
$rootScope.$new not being subsequently destroyed, but that takes up
significantly less memory).
This fix lets me run browser tests with consistent results.
Fixes #8333.