Fleet agent details design review #84939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 3, 2020 14:04
botelastic
bot
added
the
Team:Fleet
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
hbharding
added
v7.11.0
v8.0.0
release_note:skip
nchaulet
approved these changes
Dec 4, 2020
Member
nchaulet
left a comment
nchaulet
left a comment
There was a problem hiding this comment.
I pushed a changed to fixe a Type but otherwise 🚀
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
hbharding
added a commit
that referenced
this pull request
Dec 7, 2020
* small design fixs for integrations list * use tooltip for upgrade available * remove enrollment token info * remove border-bottom from last table row * Fix type issue Co-authored-by: Nicolas Chaulet <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Nicolas Chaulet <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Design review for recently merged #84434
24pxto16pxborder-bottomthat caused the integration panels to appear like they had an extra-heavy shadow. I changed this so that the border separating the panel header and the table below only appears when the panel is expanded, and I also removed the border-bottom from the last table row when it is expanded.overflow: hiddento the panel to prevent the border radius of the panel clipping with the square edge of the table.Before
After