Allows for server.host to be set in development#8487
Merged
spalger merged 1 commit intoelastic:masterfrom Oct 4, 2016
Merged
Conversation
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
spalger
approved these changes
Sep 28, 2016
Contributor
spalger
left a comment
spalger
left a comment
There was a problem hiding this comment.
LGTM. This will cause "invalid cert" errors when the host is set but ssl isn't disabled or updated to match the new hostname, but that's not necessarily a bad thing.
This was referenced Oct 4, 2016
elastic-jasper
added a commit
that referenced
this pull request
Oct 4, 2016
--------- **Commit 1:** Allows for server.host to be set in development Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Original sha: 7d76e68 * Authored by Tyler Smalley <tyler.smalley@elastic.co> on 2016-09-28T06:42:11Z
elastic-jasper
added a commit
that referenced
this pull request
Oct 4, 2016
--------- **Commit 1:** Allows for server.host to be set in development Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Original sha: 7d76e68 * Authored by Tyler Smalley <tyler.smalley@elastic.co> on 2016-09-28T06:42:11Z
epixa
added a commit
that referenced
this pull request
Oct 4, 2016
[backport] PR #8487 to 5.x - Allows for server.host to be set in development
epixa
added a commit
that referenced
this pull request
Oct 4, 2016
[backport] PR #8487 to 5.0 - Allows for server.host to be set in development
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
--------- **Commit 1:** Allows for server.host to be set in development Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Original sha: 735028b2a7bfc6b31ca422f46b2f5503c67c62e9 [formerly 7d76e68] * Authored by Tyler Smalley <tyler.smalley@elastic.co> on 2016-09-28T06:42:11Z Former-commit-id: a08d3a8
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
[backport] PR elastic#8487 to 5.x - Allows for server.host to be set in development Former-commit-id: 773032b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Kibana now defaults to localhost, it's often needed to bind to all network addresses or a specific hostname.