Conversation
mbondyra
added
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
flash1293
approved these changes
Dec 3, 2020
Contributor
flash1293
left a comment
flash1293
left a comment
There was a problem hiding this comment.
Tested in Chrome and Firefox and fixes the problem with hard-to-close field select. Looks like we need to fix the a11y issue by removing the scroll from the container.
Firefox has a really neat tool to see which element is causing the overflow and it's the last flex group, centering the "Reset layer" button:
It has a margin: -12px, if I'm removing that rule, the overflow goes away. Maybe we can center the button using custom styling instead of using FlexGroup?
mbondyra
deleted the
revert-84519-lens/accessibility/focus-on-lnsConfigPanel
branch
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Dec 3, 2020
…rm (elastic#84519)" (elastic#84866) This reverts commit a9845c6.
This was referenced Dec 3, 2020
mbondyra
added a commit
that referenced
this pull request
Dec 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #84827
Caused this bug: #84827
Reverts #84519