[Send To Background UI] Isolate functional test for wip feature #84833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
force-pushed
the
test/data/background-search-functional-config
branch
from
b75ce32 to
07b1084
Compare
tsullivan
force-pushed
the
test/data/background-search-functional-config
branch
from
07b1084 to
f712032
Compare
tsullivan
added
Feature:Functional Testing
Project:AsyncSearch
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Dosant
approved these changes
Dec 4, 2020
Contributor
Dosant
left a comment
Dosant
left a comment
There was a problem hiding this comment.
LGTM,
checked that moved tests are running and passing on CI
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Dec 4, 2020
…tic#84833) * [Send To Background UI] Isolate functional test for wip feature * add tests to cigroup 3
tsullivan
added a commit
that referenced
this pull request
Dec 4, 2020
…) (#85045) * [Send To Background UI] Isolate functional test for wip feature * add tests to cigroup 3
1 task
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem: As more functionality for Background Search is delivered to the code base, having the feature flag enabled for all X-Pack functional UI tests is a problem. Existing tests eventually fail because WIP features are present in the UI unexpectedly.
Until Background Search UI doesn't require a feature flag for normal users, the feature flag should not be set for all X-Pack tests.
This PR addresses the issue by hoisting out the test code and test services into a new area for functional testing, that includes a dedicated config. Only this config enables the feature flag for Send To Background.
Checklist
Delete any items that are not applicable to this PR.