Doc error: bin/kibana plugin doesn't restart Kibana! #8483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can one of the admins verify this patch? |
Contributor
|
Can one of the admins verify this patch? |
Author
|
I have actually signed the CLA. |
Contributor
|
I have confirmed that @ssheikholeslami has actually signed the CLA with the email currently in the commits |
spalger
suggested changes
Sep 28, 2016
docs/plugins.asciidoc
Outdated
| Use the `-c` or `--config` options to specify the path to the configuration file used to start Kibana. By default, Kibana | ||
| uses the configuration file `config/kibana.yml`. When you change your installed plugins, the `bin/kibana plugin` command | ||
| restarts the Kibana server. When you are using a customized configuration file, you must specify the | ||
| uses the configuration file `config/kibana.yml`. After you have changed the configuration file, restart the Kibana server using `service kibana stop` followed by `service kibana start`. When you are using a customized configuration file, you must specify the |
Contributor
There was a problem hiding this comment.
This is a good change, but I don't think we should mention the service command, since that only applies to specific systems with specific setups.
Author
There was a problem hiding this comment.
You're right. Well, let's say, how about this one?
uses the configuration file
config/kibana.yml. After you have changed the configuration file, you have to restart the Kibana server for changes to take effect (e.g. if Kibana is installed on an Ubuntu machine, you can restart it usingservice kibana stopfollowed byservice kibana start). When you are using a customized configuration file, you must specify the
Since the process of restarting Kibana varies from OS to OS, I've included the means to restart it on Ubuntu machines as an example.
spalger
approved these changes
Sep 30, 2016
Contributor
|
LGTM! @ssheikholeslami would you be up for submitting a similar PR against the master branch? The same section of the docs exists there, the only difference is that the name of the plugin command changed. |
elastic-jasper
added a commit
that referenced
this pull request
Oct 6, 2016
--------- **Commit 1:** Doc error: bin/kibana plugin doesn't restart Kibana! * Original sha: 7c0ff89 * Authored by Sina Sheikholeslami <ssheikholeslami@gmail.com> on 2016-09-27T15:02:13Z * Committed by GitHub <noreply@github.com> on 2016-09-27T15:02:13Z **Commit 2:** Applied requested changes. Since the process of restarting Kibana varies from OS to OS, I've included the means to restart it on Ubuntu machines as an example. * Original sha: 488d0cb * Authored by Sina Sheikholeslami <ssheikholeslami@gmail.com> on 2016-09-30T12:35:23Z * Committed by GitHub <noreply@github.com> on 2016-09-30T12:35:23Z
elastic-jasper
added a commit
that referenced
this pull request
Oct 6, 2016
--------- **Commit 1:** Doc error: bin/kibana plugin doesn't restart Kibana! * Original sha: 7c0ff89 * Authored by Sina Sheikholeslami <ssheikholeslami@gmail.com> on 2016-09-27T15:02:13Z * Committed by GitHub <noreply@github.com> on 2016-09-27T15:02:13Z **Commit 2:** Applied requested changes. Since the process of restarting Kibana varies from OS to OS, I've included the means to restart it on Ubuntu machines as an example. * Original sha: 488d0cb * Authored by Sina Sheikholeslami <ssheikholeslami@gmail.com> on 2016-09-30T12:35:23Z * Committed by GitHub <noreply@github.com> on 2016-09-30T12:35:23Z
elastic-jasper
added a commit
that referenced
this pull request
Oct 6, 2016
--------- **Commit 1:** Doc error: bin/kibana plugin doesn't restart Kibana! * Original sha: 7c0ff89 * Authored by Sina Sheikholeslami <ssheikholeslami@gmail.com> on 2016-09-27T15:02:13Z * Committed by GitHub <noreply@github.com> on 2016-09-27T15:02:13Z **Commit 2:** Applied requested changes. Since the process of restarting Kibana varies from OS to OS, I've included the means to restart it on Ubuntu machines as an example. * Original sha: 488d0cb * Authored by Sina Sheikholeslami <ssheikholeslami@gmail.com> on 2016-09-30T12:35:23Z * Committed by GitHub <noreply@github.com> on 2016-09-30T12:35:23Z
elastic-jasper
added a commit
that referenced
this pull request
Oct 6, 2016
--------- **Commit 1:** Doc error: bin/kibana plugin doesn't restart Kibana! * Original sha: 7c0ff89 * Authored by Sina Sheikholeslami <ssheikholeslami@gmail.com> on 2016-09-27T15:02:13Z * Committed by GitHub <noreply@github.com> on 2016-09-27T15:02:13Z **Commit 2:** Applied requested changes. Since the process of restarting Kibana varies from OS to OS, I've included the means to restart it on Ubuntu machines as an example. * Original sha: 488d0cb * Authored by Sina Sheikholeslami <ssheikholeslami@gmail.com> on 2016-09-30T12:35:23Z * Committed by GitHub <noreply@github.com> on 2016-09-30T12:35:23Z
This was referenced Oct 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.