fixing tile map chart fatal error when zooming in/out#8473
Closed
ppisljar wants to merge 1 commit intoelastic:masterfrom
Closed
fixing tile map chart fatal error when zooming in/out#8473ppisljar wants to merge 1 commit intoelastic:masterfrom
ppisljar wants to merge 1 commit intoelastic:masterfrom
Conversation
Contributor
|
I'd really like to make sure we can reproduce this issue before merging a fix |
Contributor
|
@LeeDr do you know of a tried-and-true way to reproduce it? For me, it's off-and-on. There's sessions that I encountered it, and others that I haven't. |
|
@thomasneirynck I only reproduced the error when doing a couple of quick zoom in's or zoom out's or mixing both. But it seemed pretty easy to hit. |
Contributor
|
Can you update the title of this PR to better reflect what is changing here (release notes worthy), and you can update to the description to describe the change in detail (blog post worthy)? |
ppisljar
changed the title
Contributor
Author
|
closing this it seems we cant reproduce the issue anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #8458 > applications throws an error, and may refresh really quickly (sometimes it does, sometimes it doesn't do that) when quickly zooming in and out in tile map visualization.
i would think that spencers PR #8439 fixed this, but @thomasneirynck reported otherwise. i was unable to reproduce the issue in the first place, but this should definetely solve it (as error complains about charts[0] not being there)