Improve logging pipeline in @kbn/legacy-logging

packages/kbn-legacy-logging/src/log_reporter.ts

@@ -17,9 +17,11 @@
  * under the License.
  */
 
+import { createWriteStream } from 'fs';
+import { pipeline } from 'stream';
+
 // @ts-expect-error missing type def
 import { Squeeze } from '@hapi/good-squeeze';
-import { createWriteStream as writeStr, WriteStream } from 'fs';
 
 import { KbnLoggerJsonFormat } from './log_format_json';
 import { KbnLoggerStringFormat } from './log_format_string';
@@ -31,21 +33,28 @@ export function getLogReporter({ events, config }: { events: any; config: LogFor
   const format = config.json ? new KbnLoggerJsonFormat(config) : new KbnLoggerStringFormat(config);
   const logInterceptor = new LogInterceptor();
 
-  let dest: WriteStream | NodeJS.WritableStream;
   if (config.dest === 'stdout') {
-    dest = process.stdout;
+    pipeline(logInterceptor, squeeze, format, onFinished);
+    // The `pipeline` function is used to properly close all streams in the
+    // pipeline in case one of them ends or fails. Since stdout obviously
+    // shouldn't be closed in case of a failure in one of the other streams,
+    // we're not including that in the call to `pipeline`, but rely on the old
+    // `pipe` function instead.
+    format.pipe(process.stdout);
   } else {
-    dest = writeStr(config.dest, {
+    const dest = createWriteStream(config.dest, {
       flags: 'a',
       encoding: 'utf8',
     });
-
-    logInterceptor.on('end', () => {
-      dest.end();
-    });
+    pipeline(logInterceptor, squeeze, format, dest, onFinished);
   }
 
-  logInterceptor.pipe(squeeze).pipe(format).pipe(dest);
-
   return logInterceptor;
 }
+
+function onFinished(err: NodeJS.ErrnoException | null) {
+  if (err) {
+    // eslint-disable-next-line no-console
+    console.error('An unexpected error occurred in the logging pipeline:', err.stack);
+  }
+}