[TSVB] Allow custom label for fields via index pattern field management #84612

alexwizp · 2020-12-01T10:23:26Z

Summary

Describe the feature:
In #70039 we have started to use custom label for fields in Discovery plugin. The same functionality needs to be implemented for TSVB too.

⚠️ Since TSVB allows you to work with multiple indexes + non-Kibana index patterns (eg Elastic indexes, Rollup indexes), we should only enable this feature if the user is using one Kibana Index Pattern for their visualization!

For those who will test this PR

Below you can find all places where lists with fields can be used:

We should be able to select Field for Metric Aggregations: Average, Cardinality, Counter Rate, Max, Min, Percentile, Percentile Rank, Std. Deviation, Sum, Sum of squares, Top Hit, Value Count, Variance
We should be able to select Field for PanelOptions -> Time Field:

Placeholder for Time Field must also support custom labels:
Custom label should be applied when there is no label for aggregation (valid for each tabs)
We should be able to select Field for Table tab -> Group by field Label should be applied also in table Header!
We should be able to select Field for TimeSeries -> Annotations
For Top Hit Aggregation we should be able for select Field for Order By
Group By -> By
Markdown Tab
Panel Options -> Override index Pattern

Checklist

Unit or functional tests were updated or added to match the most common scenarios

Closes: elastic#84336

alexwizp · 2020-12-01T15:51:07Z

@elasticmachine merge upstream

elasticmachine · 2020-12-02T14:47:45Z

Pinging @elastic/kibana-app (Team:KibanaApp)

alexwizp · 2020-12-03T12:42:47Z

@elasticmachine merge upstream

alexwizp · 2020-12-04T15:36:08Z

@elasticmachine merge upstream

alexwizp · 2020-12-07T09:54:58Z

@elasticmachine merge upstream

alexwizp · 2021-01-06T14:13:10Z

@elasticmachine merge upstream

alexwizp · 2021-01-10T11:16:45Z

@elasticmachine merge upstream

alexwizp · 2021-01-11T07:03:27Z

@elasticmachine merge upstream

src/plugins/vis_type_timeseries/common/agg_lookup.test.ts

src/plugins/vis_type_timeseries/common/agg_lookup.ts

src/plugins/vis_type_timeseries/common/extract_index_patterns.test.ts

src/plugins/vis_type_timeseries/public/application/components/aggs/cumulative_sum.js

stratoula · 2021-01-11T10:34:53Z

src/plugins/vis_type_timeseries/public/application/components/aggs/field_select.tsx

+    }
+  });
+
+  if (type === METRIC_TYPES.COUNT) {


Maybe it would be a good idea to move this check in the beginning of the component. As it returns null for this type. no need to run the rest of the code, right?

I think this component should be refactored to use useEffect instead. But agree as a fast enhancement we can move that if up

Agree but let's do this for now ❤️

src/plugins/vis_type_timeseries/public/application/components/aggs/metric_select.js

src/plugins/vis_type_timeseries/public/application/components/aggs/positive_only.js

src/plugins/vis_type_timeseries/public/application/components/aggs/serial_diff.js

src/plugins/vis_type_timeseries/public/application/components/aggs/std_sibling.js

stratoula

LGTM, tested on Safari and seems to work fine.

sulemanof

LGTM 👍
Tested in Chrome, works perfect 💕

src/plugins/vis_type_timeseries/common/to_percentile_number.js

src/plugins/vis_type_timeseries/server/lib/vis_data/get_series_data.js

alexwizp · 2021-01-12T14:12:25Z

@elasticmachine merge upstream

kibanamachine · 2021-01-12T16:27:27Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: d3af133

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`visTypeTimeseries`	1.8MB	1.7MB	-24.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`visTypeTimeseries`	143.6KB	136.8KB	-6.8KB

History

💚 Build #97885 succeeded 206c46a
💔 Build #97872 failed 2dc7ca2
💛 Build #97797 was flaky 17189a3
💛 Build #97779 was flaky a91014c
💚 Build #97275 succeeded 26d5e25

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…nt (elastic#84612) * [TSVB] Allow custom label for fields via index pattern field management Closes: elastic#84336 * replace saveObject, elasticsearch client to new one * fix CI * update schema * fix Top Hit * some changes * partially move getting fields into client side * fix PR comments * fix issue with getting fields * move SanitizedFieldType to common types * fix issue on changing index pattern * fix issue * fix regression * some work * remove extractFieldName, createCustomLabelSelectHandler * request/response processors should be async * some work * remove tests for createCustomLabelSelectHandler * fix table * fix placeholder * some work * fix jest * fix CI * fix label for table view * test: visualize app visual builder switch index patterns should be able to switch between index patterns * fix functional tests * fix sorting * fix labels for entire timerange mode * add createFieldsFetcher method * table view - fix pivot label * fix PR comments * fix issue with selecting buckets scripts * fix types * Update create_select_handler.test.ts * fix PR comments Co-authored-by: Kibana Machine <[email protected]>

…nt (#84612) (#88074) * [TSVB] Allow custom label for fields via index pattern field management Closes: #84336 * replace saveObject, elasticsearch client to new one * fix CI * update schema * fix Top Hit * some changes * partially move getting fields into client side * fix PR comments * fix issue with getting fields * move SanitizedFieldType to common types * fix issue on changing index pattern * fix issue * fix regression * some work * remove extractFieldName, createCustomLabelSelectHandler * request/response processors should be async * some work * remove tests for createCustomLabelSelectHandler * fix table * fix placeholder * some work * fix jest * fix CI * fix label for table view * test: visualize app visual builder switch index patterns should be able to switch between index patterns * fix functional tests * fix sorting * fix labels for entire timerange mode * add createFieldsFetcher method * table view - fix pivot label * fix PR comments * fix issue with selecting buckets scripts * fix types * Update create_select_handler.test.ts * fix PR comments Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>

[TSVB] Allow custom label for fields via index pattern field management

f5b9887

Closes: elastic#84336

alexwizp force-pushed the custom-label-1 branch from 28f0c02 to f5b9887 Compare December 1, 2020 12:56

alexwizp added 5 commits December 1, 2020 16:36

replace saveObject, elasticsearch client to new one

1a17c60

fix CI

234612d

update schema

8567a31

fix Top Hit

dc5e4a0

Merge remote-tracking branch 'upstream/master' into custom-label-1

1a4f32a

elastic deleted a comment from kibanamachine Dec 1, 2020

alexwizp mentioned this pull request Dec 1, 2020

[Data plugin] Wrong caching for Index pattern fields #84666

Closed

kibanamachine and others added 2 commits December 1, 2020 10:51

Merge branch 'master' into custom-label-1

1a8148a

Merge remote-tracking branch 'upstream/master' into custom-label-1

63521f8

alexwizp force-pushed the custom-label-1 branch from bf9accd to 06f8e71 Compare December 2, 2020 09:26

some changes

640d89c

alexwizp force-pushed the custom-label-1 branch from 06f8e71 to 640d89c Compare December 2, 2020 09:31

alexwizp requested review from stratoula and timroes December 2, 2020 11:08

alexwizp added v7.11.0 v8.0.0 Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// Feature:TSVB TSVB (Time Series Visual Builder) release_note:enhancement labels Dec 2, 2020

alexwizp marked this pull request as ready for review December 2, 2020 14:47

alexwizp requested a review from a team December 2, 2020 14:47

Merge branch 'master' into custom-label-1

85b3ad3

Merge branch 'master' into custom-label-1

99e6a23

fix sorting

a0396b3

alexwizp requested review from stratoula and sulemanof January 6, 2021 10:29

alexwizp added 3 commits January 6, 2021 15:23

fix labels for entire timerange mode

65475b0

add createFieldsFetcher method

1f92cc6

table view - fix pivot label

9ee914a

alexwizp changed the title ~~[WIP][TSVB] Allow custom label for fields via index pattern field management~~ [TSVB] Allow custom label for fields via index pattern field management Jan 6, 2021

alexwizp removed the WIP Work in progress label Jan 6, 2021

Merge branch 'master' into custom-label-1

26d5e25

Merge branch 'master' into custom-label-1

a91014c

Merge branch 'master' into custom-label-1

17189a3

stratoula reviewed Jan 11, 2021

View reviewed changes

stratoula self-requested a review January 11, 2021 10:55

alexwizp added 4 commits January 11, 2021 14:49

fix PR comments

0aebc8a

fix issue with selecting buckets scripts

2dc7ca2

fix types

64444ae

Update create_select_handler.test.ts

206c46a

stratoula approved these changes Jan 11, 2021

View reviewed changes

sulemanof approved these changes Jan 12, 2021

View reviewed changes

src/plugins/vis_type_timeseries/common/to_percentile_number.js Outdated Show resolved Hide resolved

src/plugins/vis_type_timeseries/server/lib/vis_data/get_series_data.js Outdated Show resolved Hide resolved

fix PR comments

a43cde3

Merge branch 'master' into custom-label-1

d3af133

alexwizp merged commit 0b7e83f into elastic:master Jan 12, 2021

alexwizp mentioned this pull request Jan 12, 2021

[7.x] [TSVB] Allow custom label for fields via index pattern field management (#84612) #88074

Merged

[TSVB] Allow custom label for fields via index pattern field management #84612

[TSVB] Allow custom label for fields via index pattern field management #84612

Uh oh!

Conversation

alexwizp commented Dec 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

For those who will test this PR

Checklist

Uh oh!

alexwizp commented Dec 1, 2020

Uh oh!

elasticmachine commented Dec 2, 2020

Uh oh!

alexwizp commented Dec 3, 2020

Uh oh!

alexwizp commented Dec 4, 2020

Uh oh!

alexwizp commented Dec 7, 2020

Uh oh!

alexwizp commented Jan 6, 2021

Uh oh!

alexwizp commented Jan 10, 2021

Uh oh!

alexwizp commented Jan 11, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stratoula Jan 11, 2021

Choose a reason for hiding this comment

Uh oh!

alexwizp Jan 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stratoula Jan 11, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stratoula left a comment

Choose a reason for hiding this comment

Uh oh!

sulemanof left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

alexwizp commented Jan 12, 2021

Uh oh!

kibanamachine commented Jan 12, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

alexwizp commented Dec 1, 2020 •

edited

Loading

alexwizp Jan 11, 2021 •

edited

Loading